[Flight] Respect async flag in client manifest (#30959)

In #26624, the ability to mark a client reference module as `async` in the React client manifest was removed because it was not utilized by Webpack, neither in `ReactFlightWebpackPlugin` nor in Next.js. However, some bundlers and frameworks are sophisticated enough to properly handle and identify async ESM modules (e.g., client component modules with top-level `await`), most notably Turbopack in Next.js. Therefore, we need to consider the `async` flag in the client manifest when resolving the client reference metadata on the server. The SSR manifest cannot override this flag, meaning that if a module is async, it must remain async in all client environments. x-ref: vercel/next.js#70022 DiffTrain build for [5deb782](5deb782)
facebook · Sep 13, 2024 · 0252a0b · 0252a0b
1 parent d65fb06
commit 0252a0b
Show file tree

Hide file tree

Showing 34 changed files with 185 additions and 203 deletions.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-d9c4920e8b3fff3d3da24d14adf7ac884aee55b2
+5deb78223a269a6cb1706da8ec6aad8c007cab03
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-d9c4920e8b3fff3d3da24d14adf7ac884aee55b2
+5deb78223a269a6cb1706da8ec6aad8c007cab03
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -2001,7 +2001,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.0.0-www-classic-d9c4920e-20240913";
+    exports.version = "19.0.0-www-classic-5deb7822-20240913";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -1981,7 +1981,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.0.0-www-modern-d9c4920e-20240913";
+    exports.version = "19.0.0-www-modern-5deb7822-20240913";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-classic-d9c4920e-20240913";
+exports.version = "19.0.0-www-classic-5deb7822-20240913";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-modern-d9c4920e-20240913";
+exports.version = "19.0.0-www-modern-5deb7822-20240913";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-classic-d9c4920e-20240913";
+exports.version = "19.0.0-www-classic-5deb7822-20240913";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-modern-d9c4920e-20240913";
+exports.version = "19.0.0-www-modern-5deb7822-20240913";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -17112,11 +17112,11 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.0.0-www-classic-d9c4920e-20240913",
+        version: "19.0.0-www-classic-5deb7822-20240913",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getInstanceFromNode,
-        reconcilerVersion: "19.0.0-www-classic-d9c4920e-20240913"
+        reconcilerVersion: "19.0.0-www-classic-5deb7822-20240913"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -17150,7 +17150,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.0.0-www-classic-d9c4920e-20240913";
+    exports.version = "19.0.0-www-classic-5deb7822-20240913";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -16558,11 +16558,11 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.0.0-www-modern-d9c4920e-20240913",
+        version: "19.0.0-www-modern-5deb7822-20240913",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getInstanceFromNode,
-        reconcilerVersion: "19.0.0-www-modern-d9c4920e-20240913"
+        reconcilerVersion: "19.0.0-www-modern-5deb7822-20240913"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16596,7 +16596,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.0.0-www-modern-d9c4920e-20240913";
+    exports.version = "19.0.0-www-modern-5deb7822-20240913";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -10883,13 +10883,13 @@ var slice = Array.prototype.slice,
   })(React.Component);
 var internals$jscomp$inline_1424 = {
   bundleType: 0,
-  version: "19.0.0-www-classic-d9c4920e-20240913",
+  version: "19.0.0-www-classic-5deb7822-20240913",
   rendererPackageName: "react-art",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: function () {
     return null;
   },
-  reconcilerVersion: "19.0.0-www-classic-d9c4920e-20240913"
+  reconcilerVersion: "19.0.0-www-classic-5deb7822-20240913"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1425 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10915,4 +10915,4 @@ exports.RadialGradient = RadialGradient;
 exports.Shape = TYPES.SHAPE;
 exports.Surface = Surface;
 exports.Text = Text;
-exports.version = "19.0.0-www-classic-d9c4920e-20240913";
+exports.version = "19.0.0-www-classic-5deb7822-20240913";
diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -10397,13 +10397,13 @@ var slice = Array.prototype.slice,
   })(React.Component);
 var internals$jscomp$inline_1416 = {
   bundleType: 0,
-  version: "19.0.0-www-modern-d9c4920e-20240913",
+  version: "19.0.0-www-modern-5deb7822-20240913",
   rendererPackageName: "react-art",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: function () {
     return null;
   },
-  reconcilerVersion: "19.0.0-www-modern-d9c4920e-20240913"
+  reconcilerVersion: "19.0.0-www-modern-5deb7822-20240913"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1417 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10429,4 +10429,4 @@ exports.RadialGradient = RadialGradient;
 exports.Shape = TYPES.SHAPE;
 exports.Surface = Surface;
 exports.Text = Text;
-exports.version = "19.0.0-www-modern-d9c4920e-20240913";
+exports.version = "19.0.0-www-modern-5deb7822-20240913";
diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -18666,41 +18666,43 @@ __DEV__ &&
         : !1;
     }
     function getActiveElementDeep(containerInfo) {
-      var $jscomp$optchain$tmp1124481893$1, $jscomp$nullish$tmp0;
+      var $jscomp$optchain$tmpm1151065292$1, $jscomp$nullish$tmp0;
       containerInfo =
         null !=
         ($jscomp$nullish$tmp0 =
           null == containerInfo
             ? void 0
             : null ==
-                ($jscomp$optchain$tmp1124481893$1 = containerInfo.ownerDocument)
+                ($jscomp$optchain$tmpm1151065292$1 =
+                  containerInfo.ownerDocument)
               ? void 0
-              : $jscomp$optchain$tmp1124481893$1.defaultView)
+              : $jscomp$optchain$tmpm1151065292$1.defaultView)
           ? $jscomp$nullish$tmp0
           : window;
       for (
-        $jscomp$optchain$tmp1124481893$1 = getActiveElement(
+        $jscomp$optchain$tmpm1151065292$1 = getActiveElement(
           containerInfo.document
         );
-        $jscomp$optchain$tmp1124481893$1 instanceof
+        $jscomp$optchain$tmpm1151065292$1 instanceof
         containerInfo.HTMLIFrameElement;
 
       ) {
         try {
           var JSCompiler_inline_result =
             "string" ===
-            typeof $jscomp$optchain$tmp1124481893$1.contentWindow.location.href;
+            typeof $jscomp$optchain$tmpm1151065292$1.contentWindow.location
+              .href;
         } catch (err) {
           JSCompiler_inline_result = !1;
         }
         if (JSCompiler_inline_result)
-          containerInfo = $jscomp$optchain$tmp1124481893$1.contentWindow;
+          containerInfo = $jscomp$optchain$tmpm1151065292$1.contentWindow;
         else break;
-        $jscomp$optchain$tmp1124481893$1 = getActiveElement(
+        $jscomp$optchain$tmpm1151065292$1 = getActiveElement(
           containerInfo.document
         );
       }
-      return $jscomp$optchain$tmp1124481893$1;
+      return $jscomp$optchain$tmpm1151065292$1;
     }
     function hasSelectionCapabilities(elem) {
       var nodeName = elem && elem.nodeName && elem.nodeName.toLowerCase();
@@ -27866,11 +27868,11 @@ __DEV__ &&
         : flushSyncErrorInBuildsThatSupportLegacyMode;
     (function () {
       var isomorphicReactPackageVersion = React.version;
-      if ("19.0.0-www-classic-d9c4920e-20240913" !== isomorphicReactPackageVersion)
+      if ("19.0.0-www-classic-5deb7822-20240913" !== isomorphicReactPackageVersion)
         throw Error(
           'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n  - react:      ' +
             (isomorphicReactPackageVersion +
-              "\n  - react-dom:  19.0.0-www-classic-d9c4920e-20240913\nLearn more: https://react.dev/warnings/version-mismatch")
+              "\n  - react-dom:  19.0.0-www-classic-5deb7822-20240913\nLearn more: https://react.dev/warnings/version-mismatch")
         );
     })();
     ("function" === typeof Map &&
@@ -27914,11 +27916,11 @@ __DEV__ &&
       !(function () {
         var internals = {
           bundleType: 1,
-          version: "19.0.0-www-classic-d9c4920e-20240913",
+          version: "19.0.0-www-classic-5deb7822-20240913",
           rendererPackageName: "react-dom",
           currentDispatcherRef: ReactSharedInternals,
           findFiberByHostInstance: getClosestInstanceFromNode,
-          reconcilerVersion: "19.0.0-www-classic-d9c4920e-20240913"
+          reconcilerVersion: "19.0.0-www-classic-5deb7822-20240913"
         };
         internals.overrideHookState = overrideHookState;
         internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -28571,7 +28573,7 @@ __DEV__ &&
     exports.useFormStatus = function () {
       return resolveDispatcher().useHostTransitionStatus();
     };
-    exports.version = "19.0.0-www-classic-d9c4920e-20240913";
+    exports.version = "19.0.0-www-classic-5deb7822-20240913";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -18000,41 +18000,41 @@ __DEV__ &&
         : !1;
     }
     function getActiveElementDeep(containerInfo) {
-      var $jscomp$optchain$tmpm676377794$1, $jscomp$nullish$tmp0;
+      var $jscomp$optchain$tmp1941505231$1, $jscomp$nullish$tmp0;
       containerInfo =
         null !=
         ($jscomp$nullish$tmp0 =
           null == containerInfo
             ? void 0
             : null ==
-                ($jscomp$optchain$tmpm676377794$1 = containerInfo.ownerDocument)
+                ($jscomp$optchain$tmp1941505231$1 = containerInfo.ownerDocument)
               ? void 0
-              : $jscomp$optchain$tmpm676377794$1.defaultView)
+              : $jscomp$optchain$tmp1941505231$1.defaultView)
           ? $jscomp$nullish$tmp0
           : window;
       for (
-        $jscomp$optchain$tmpm676377794$1 = getActiveElement(
+        $jscomp$optchain$tmp1941505231$1 = getActiveElement(
           containerInfo.document
         );
-        $jscomp$optchain$tmpm676377794$1 instanceof
+        $jscomp$optchain$tmp1941505231$1 instanceof
         containerInfo.HTMLIFrameElement;
 
       ) {
         try {
           var JSCompiler_inline_result =
             "string" ===
-            typeof $jscomp$optchain$tmpm676377794$1.contentWindow.location.href;
+            typeof $jscomp$optchain$tmp1941505231$1.contentWindow.location.href;
         } catch (err) {
           JSCompiler_inline_result = !1;
         }
         if (JSCompiler_inline_result)
-          containerInfo = $jscomp$optchain$tmpm676377794$1.contentWindow;
+          containerInfo = $jscomp$optchain$tmp1941505231$1.contentWindow;
         else break;
-        $jscomp$optchain$tmpm676377794$1 = getActiveElement(
+        $jscomp$optchain$tmp1941505231$1 = getActiveElement(
           containerInfo.document
         );
       }
-      return $jscomp$optchain$tmpm676377794$1;
+      return $jscomp$optchain$tmp1941505231$1;
     }
     function hasSelectionCapabilities(elem) {
       var nodeName = elem && elem.nodeName && elem.nodeName.toLowerCase();
@@ -26983,11 +26983,11 @@ __DEV__ &&
       return_targetInst = null;
     (function () {
       var isomorphicReactPackageVersion = React.version;
-      if ("19.0.0-www-modern-d9c4920e-20240913" !== isomorphicReactPackageVersion)
+      if ("19.0.0-www-modern-5deb7822-20240913" !== isomorphicReactPackageVersion)
         throw Error(
           'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n  - react:      ' +
             (isomorphicReactPackageVersion +
-              "\n  - react-dom:  19.0.0-www-modern-d9c4920e-20240913\nLearn more: https://react.dev/warnings/version-mismatch")
+              "\n  - react-dom:  19.0.0-www-modern-5deb7822-20240913\nLearn more: https://react.dev/warnings/version-mismatch")
         );
     })();
     ("function" === typeof Map &&
@@ -27030,11 +27030,11 @@ __DEV__ &&
       !(function () {
         var internals = {
           bundleType: 1,
-          version: "19.0.0-www-modern-d9c4920e-20240913",
+          version: "19.0.0-www-modern-5deb7822-20240913",
           rendererPackageName: "react-dom",
           currentDispatcherRef: ReactSharedInternals,
           findFiberByHostInstance: getClosestInstanceFromNode,
-          reconcilerVersion: "19.0.0-www-modern-d9c4920e-20240913"
+          reconcilerVersion: "19.0.0-www-modern-5deb7822-20240913"
         };
         internals.overrideHookState = overrideHookState;
         internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27639,7 +27639,7 @@ __DEV__ &&
     exports.useFormStatus = function () {
       return resolveDispatcher().useHostTransitionStatus();
     };
-    exports.version = "19.0.0-www-modern-d9c4920e-20240913";
+    exports.version = "19.0.0-www-modern-5deb7822-20240913";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&