lint: enable reportUnusedDisableDirectives and remove unused suppress…

…ions (#28721) This enables linting against unused suppressions and removes the ones that were unused.
facebook · Jun 21, 2024 · b565373 · b565373
1 parent 3563387
commit b565373
Show file tree

Hide file tree

Showing 66 changed files with 44 additions and 148 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -17,6 +17,8 @@ module.exports = {
   // Stop ESLint from looking for a configuration file in parent folders
   root: true,
 
+  reportUnusedDisableDirectives: true,
+
   plugins: [
     'babel',
     'ft-flow',

diff --git a/packages/react-client/src/ReactFlightClient.js b/packages/react-client/src/ReactFlightClient.js
@@ -1839,7 +1839,6 @@ function resolveHint<Code: HintCode>(
   dispatchHint(code, hintModel);
 }
 
-// eslint-disable-next-line react-internal/no-production-logging
 const supportsCreateTask =
   __DEV__ && enableOwnerStacks && !!(console: any).createTask;
 
@@ -1977,7 +1976,6 @@ function initializeFakeTask(
       ? null
       : initializeFakeTask(response, componentInfo.owner);
 
-  // eslint-disable-next-line react-internal/no-production-logging
   const createTaskFn = (console: any).createTask.bind(
     console,
     getServerComponentTaskName(componentInfo),

diff --git a/packages/react-client/src/ReactFlightReplyClient.js b/packages/react-client/src/ReactFlightReplyClient.js
@@ -227,14 +227,11 @@ export function processReply(
     function progress(entry: {done: boolean, value: ReactServerValue, ...}) {
       if (entry.done) {
         const blobId = nextPartId++;
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(formFieldPrefix + blobId, new Blob(buffer));
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(
           formFieldPrefix + streamId,
           '"$o' + blobId.toString(16) + '"',
         );
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(formFieldPrefix + streamId, 'C'); // Close signal
         pendingParts--;
         if (pendingParts === 0) {
@@ -262,7 +259,6 @@ export function processReply(
 
     function progress(entry: {done: boolean, value: ReactServerValue, ...}) {
       if (entry.done) {
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(formFieldPrefix + streamId, 'C'); // Close signal
         pendingParts--;
         if (pendingParts === 0) {
@@ -272,7 +268,6 @@ export function processReply(
         try {
           // $FlowFixMe[incompatible-type]: While plain JSON can return undefined we never do here.
           const partJSON: string = JSON.stringify(entry.value, resolveToJSON);
-          // eslint-disable-next-line react-internal/safe-string-coercion
           data.append(formFieldPrefix + streamId, partJSON);
           reader.read().then(progress, reject);
         } catch (x) {
@@ -326,7 +321,6 @@ export function processReply(
     ) {
       if (entry.done) {
         if (entry.value === undefined) {
-          // eslint-disable-next-line react-internal/safe-string-coercion
           data.append(formFieldPrefix + streamId, 'C'); // Close signal
         } else {
           // Unlike streams, the last value may not be undefined. If it's not
@@ -348,7 +342,6 @@ export function processReply(
         try {
           // $FlowFixMe[incompatible-type]: While plain JSON can return undefined we never do here.
           const partJSON: string = JSON.stringify(entry.value, resolveToJSON);
-          // eslint-disable-next-line react-internal/safe-string-coercion
           data.append(formFieldPrefix + streamId, partJSON);
           iterator.next().then(progress, reject);
         } catch (x) {
@@ -441,7 +434,6 @@ export function processReply(
             const partJSON = serializeModel(resolvedModel, lazyId);
             // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
             const data: FormData = formData;
-            // eslint-disable-next-line react-internal/safe-string-coercion
             data.append(formFieldPrefix + lazyId, partJSON);
             return serializeByValueID(lazyId);
           } catch (x) {
@@ -461,7 +453,6 @@ export function processReply(
                   const partJSON = serializeModel(value, lazyId);
                   // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
                   const data: FormData = formData;
-                  // eslint-disable-next-line react-internal/safe-string-coercion
                   data.append(formFieldPrefix + lazyId, partJSON);
                   pendingParts--;
                   if (pendingParts === 0) {
@@ -502,7 +493,6 @@ export function processReply(
               const partJSON = serializeModel(partValue, promiseId);
               // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
               const data: FormData = formData;
-              // eslint-disable-next-line react-internal/safe-string-coercion
               data.append(formFieldPrefix + promiseId, partJSON);
               pendingParts--;
               if (pendingParts === 0) {
@@ -784,7 +774,6 @@ export function processReply(
         }
         // The reference to this function came from the same client so we can pass it back.
         const refId = nextPartId++;
-        // eslint-disable-next-line react-internal/safe-string-coercion
         formData.set(formFieldPrefix + refId, metaDataJSON);
         return serializeServerReferenceID(refId);
       }

diff --git a/packages/react-client/src/forks/ReactFlightClientConfig.custom.js b/packages/react-client/src/forks/ReactFlightClientConfig.custom.js
@@ -42,7 +42,7 @@ export const usedWithSSR = true;
 
 export opaque type Source = mixed;
 
-export opaque type StringDecoder = mixed; // eslint-disable-line no-undef
+export opaque type StringDecoder = mixed;
 
 export const createStringDecoder = $$$config.createStringDecoder;
 export const readPartialStringChunk = $$$config.readPartialStringChunk;

diff --git a/packages/react-devtools-extensions/flow-typed/jest.js b/packages/react-devtools-extensions/flow-typed/jest.js
@@ -146,13 +146,11 @@ type JestPromiseType = {
    * Use rejects to unwrap the reason of a rejected promise so any other
    * matcher can be chained. If the promise is fulfilled the assertion fails.
    */
-  // eslint-disable-next-line no-use-before-define
   rejects: JestExpectType,
   /**
    * Use resolves to unwrap the value of a fulfilled promise so any other
    * matcher can be chained. If the promise is rejected the assertion fails.
    */
-  // eslint-disable-next-line no-use-before-define
   resolves: JestExpectType,
 };
 
@@ -1098,10 +1096,8 @@ type JestPrettyFormatColors = {
 };
 
 type JestPrettyFormatIndent = string => string;
-// eslint-disable-next-line no-unused-vars
 type JestPrettyFormatRefs = Array<any>;
 type JestPrettyFormatPrint = any => string;
-// eslint-disable-next-line no-unused-vars
 type JestPrettyFormatStringOrNull = string | null;
 
 type JestPrettyFormatOptions = {
@@ -1112,7 +1108,6 @@ type JestPrettyFormatOptions = {
   indent: number,
   maxDepth: number,
   min: boolean,
-  // eslint-disable-next-line no-use-before-define
   plugins: JestPrettyFormatPlugins,
   printFunctionName: boolean,
   spacing: string,

diff --git a/packages/react-devtools-extensions/flow-typed/npm/react-test-renderer_v16.x.x.js b/packages/react-devtools-extensions/flow-typed/npm/react-test-renderer_v16.x.x.js
@@ -52,7 +52,6 @@ type TestRendererOptions = {
 };
 
 declare module 'react-test-renderer' {
-  // eslint-disable-next-line no-inner-declarations
   declare export type ReactTestRenderer = {
     toJSON(): null | ReactTestRendererJSON,
     toTree(): null | ReactTestRendererTree,

diff --git a/packages/react-devtools-inline/__tests__/__e2e__/utils.js b/packages/react-devtools-inline/__tests__/__e2e__/utils.js
@@ -7,7 +7,6 @@ const config = require('../../playwright.config');
 const {test} = require('@playwright/test');
 
 function runOnlyForReactRange(range) {
-  // eslint-disable-next-line jest/no-disabled-tests
   test.skip(
     !semver.satisfies(config.use.react_version, range),
     `This test requires a React version of ${range} to run. ` +

diff --git a/packages/react-devtools-shared/src/__tests__/inspectedElement-test.js b/packages/react-devtools-shared/src/__tests__/inspectedElement-test.js
@@ -665,7 +665,6 @@ describe('InspectedElement', () => {
           anonymous_fn={instance.anonymousFunction}
           array_buffer={arrayBuffer}
           array_of_arrays={arrayOfArrays}
-          // eslint-disable-next-line no-undef
           big_int={BigInt(123)}
           bound_fn={exampleFunction.bind(this)}
           data_view={dataView}
@@ -1876,7 +1875,7 @@ describe('InspectedElement', () => {
         xyz: 1,
       },
     });
-    const bigInt = BigInt(123); // eslint-disable-line no-undef
+    const bigInt = BigInt(123);
 
     await utils.actAsync(() =>
       render(

diff --git a/packages/react-devtools-shared/src/__tests__/legacy/inspectElement-test.js b/packages/react-devtools-shared/src/__tests__/legacy/inspectElement-test.js
@@ -185,7 +185,6 @@ describe('InspectedElementContext', () => {
           anonymous_fn: instance.anonymousFunction,
           array_buffer: arrayBuffer,
           array_of_arrays: arrayOfArrays,
-          // eslint-disable-next-line no-undef
           big_int: BigInt(123),
           bound_fn: exampleFunction.bind(this),
           data_view: dataView,
@@ -888,7 +887,7 @@ describe('InspectedElementContext', () => {
         xyz: 1,
       },
     });
-    const bigInt = BigInt(123); // eslint-disable-line no-undef
+    const bigInt = BigInt(123);
 
     act(() =>
       ReactDOM.render(

diff --git a/packages/react-devtools-shared/src/backend/DevToolsConsolePatching.js b/packages/react-devtools-shared/src/backend/DevToolsConsolePatching.js
@@ -30,7 +30,6 @@ disabledLog.__reactDisabledLog = true;
 
 export function disableLogs(): void {
   if (disabledDepth === 0) {
-    /* eslint-disable react-internal/no-production-logging */
     prevLog = console.log;
     prevInfo = console.info;
     prevWarn = console.warn;
@@ -63,7 +62,6 @@ export function disableLogs(): void {
 export function reenableLogs(): void {
   disabledDepth--;
   if (disabledDepth === 0) {
-    /* eslint-disable react-internal/no-production-logging */
     const props = {
       configurable: true,
       enumerable: true,

diff --git a/packages/react-devtools-shared/src/backend/renderer.js b/packages/react-devtools-shared/src/backend/renderer.js
@@ -1604,7 +1604,6 @@ export function attach(
     return changedKeys;
   }
 
-  // eslint-disable-next-line no-unused-vars
   function didFiberRender(prevFiber: Fiber, nextFiber: Fiber): boolean {
     switch (nextFiber.tag) {
       case ClassComponent:

diff --git a/packages/react-devtools-shell/src/app/InspectableElements/UnserializableProps.js b/packages/react-devtools-shell/src/app/InspectableElements/UnserializableProps.js
@@ -31,7 +31,7 @@ const immutable = Immutable.fromJS({
     xyz: 1,
   },
 });
-const bigInt = BigInt(123); // eslint-disable-line no-undef
+const bigInt = BigInt(123);
 
 class Foo {
   flag = false;

diff --git a/packages/react-devtools/app.js b/packages/react-devtools/app.js
@@ -46,7 +46,7 @@ app.on('ready', function () {
   });
 
   // and load the index.html of the app.
-  mainWindow.loadURL('file://' + __dirname + '/app.html'); // eslint-disable-line no-path-concat
+  mainWindow.loadURL('file://' + __dirname + '/app.html');
   // $FlowFixMe[incompatible-use] found when upgrading Flow
   mainWindow.webContents.executeJavaScript(
     // We use this so that RN can keep relative JSX __source filenames

diff --git a/packages/react-dom-bindings/src/client/DOMPropertyOperations.js b/packages/react-dom-bindings/src/client/DOMPropertyOperations.js
@@ -30,7 +30,7 @@ export function getValueForAttribute(
       // shouldRemoveAttribute
       switch (typeof expected) {
         case 'function':
-        case 'symbol': // eslint-disable-line
+        case 'symbol':
           return expected;
         case 'boolean': {
           const prefix = name.toLowerCase().slice(0, 5);
@@ -109,7 +109,7 @@ export function setValueForAttribute(
     switch (typeof value) {
       case 'undefined':
       case 'function':
-      case 'symbol': // eslint-disable-line
+      case 'symbol':
         node.removeAttribute(name);
         return;
       case 'boolean': {

diff --git a/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js b/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
@@ -443,7 +443,7 @@ export function createInstance(
               didWarnScriptTags = true;
             }
           }
-          div.innerHTML = '<script><' + '/script>'; // eslint-disable-line
+          div.innerHTML = '<script><' + '/script>';
           // This is guaranteed to yield a script element.
           const firstChild = ((div.firstChild: any): HTMLScriptElement);
           domElement = div.removeChild(firstChild);

diff --git a/packages/react-dom-bindings/src/client/validateDOMNesting.js b/packages/react-dom-bindings/src/client/validateDOMNesting.js
@@ -516,7 +516,6 @@ function validateTextNesting(childText: string, parentTag: string): boolean {
       return true;
     }
 
-    // eslint-disable-next-line react-internal/safe-string-coercion
     const warnKey = '#text|' + parentTag;
     if (didWarn[warnKey]) {
       return false;

diff --git a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js
@@ -1464,7 +1464,7 @@ function pushAttribute(
         // shouldRemoveAttribute
         switch (typeof value) {
           case 'function':
-          case 'symbol': // eslint-disable-line
+          case 'symbol':
             return;
           case 'boolean': {
             const prefix = attributeName.toLowerCase().slice(0, 5);
@@ -2808,7 +2808,6 @@ function pushStyleImpl(
     child !== null &&
     child !== undefined
   ) {
-    // eslint-disable-next-line react-internal/safe-string-coercion
     target.push(stringToChunk(escapeStyleTextContent(child)));
   }
   pushInnerHTML(target, innerHTML, children);
@@ -2850,7 +2849,6 @@ function pushStyleContents(
     child !== null &&
     child !== undefined
   ) {
-    // eslint-disable-next-line react-internal/safe-string-coercion
     target.push(stringToChunk(escapeStyleTextContent(child)));
   }
   pushInnerHTML(target, innerHTML, children);

diff --git a/packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js b/packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js
@@ -271,7 +271,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
         }
       }
       case 'function':
-      case 'symbol': // eslint-disable-line
+      case 'symbol':
         // Warn when a known attribute is a bad type
         warnedProperties[name] = true;
         return false;

diff --git a/packages/react-dom-bindings/src/shared/isAttributeNameSafe.js b/packages/react-dom-bindings/src/shared/isAttributeNameSafe.js
@@ -9,10 +9,8 @@
 
 import hasOwnProperty from 'shared/hasOwnProperty';
 
-/* eslint-disable max-len */
 const ATTRIBUTE_NAME_START_CHAR =
   ':A-Z_a-z\\u00C0-\\u00D6\\u00D8-\\u00F6\\u00F8-\\u02FF\\u0370-\\u037D\\u037F-\\u1FFF\\u200C-\\u200D\\u2070-\\u218F\\u2C00-\\u2FEF\\u3001-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFFD';
-/* eslint-enable max-len */
 export const ATTRIBUTE_NAME_CHAR: string =
   ATTRIBUTE_NAME_START_CHAR + '\\-.0-9\\u00B7\\u0300-\\u036F\\u203F-\\u2040';
 

diff --git a/packages/react-dom-bindings/src/shared/sanitizeURL.js b/packages/react-dom-bindings/src/shared/sanitizeURL.js
@@ -16,7 +16,6 @@
 // INFORMATION SEPARATOR ONE, inclusive:
 // https://infra.spec.whatwg.org/#c0-control-or-space
 
-/* eslint-disable max-len */
 const isJavaScriptProtocol =
   /^[\u0000-\u001F ]*j[\r\n\t]*a[\r\n\t]*v[\r\n\t]*a[\r\n\t]*s[\r\n\t]*c[\r\n\t]*r[\r\n\t]*i[\r\n\t]*p[\r\n\t]*t[\r\n\t]*\:/i;
 

diff --git a/packages/react-dom/src/__tests__/ReactComponent-test.js b/packages/react-dom/src/__tests__/ReactComponent-test.js
@@ -468,7 +468,6 @@ describe('ReactComponent', () => {
       root.unmount();
     });
 
-    /* eslint-disable indent */
     expect(log).toEqual([
       'start mount',
       'inner 1 render',
@@ -497,7 +496,6 @@ describe('ReactComponent', () => {
       'ref 2 got null',
       'inner 2 componentWillUnmount',
     ]);
-    /* eslint-enable indent */
   });
 
   // @gate !disableLegacyMode

diff --git a/packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js b/packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
@@ -1503,7 +1503,6 @@ describe('ReactComponentLifeCycle', () => {
       });
     }).toWarnDev(
       [
-        /* eslint-disable max-len */
         `componentWillMount has been renamed, and is not recommended for use. See https://react.dev/link/unsafe-component-lifecycles for details.
 
 * Move code with side effects to componentDidMount, and set initial state in the constructor.
@@ -1523,7 +1522,6 @@ Please update the following components: MyComponent`,
 * Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run \`npx react-codemod rename-unsafe-lifecycles\` in your project source folder.
 
 Please update the following components: MyComponent`,
-        /* eslint-enable max-len */
       ],
       {withoutStack: true},
     );

diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js
@@ -744,7 +744,7 @@ describe('ReactDOMServerIntegration', () => {
         'a div with a single child surrounded by whitespace',
         async render => {
           // prettier-ignore
-          const e = await render(<div id="parent">  <div id="child" />   </div>); // eslint-disable-line no-multi-spaces
+          const e = await render(<div id="parent">  <div id="child" />   </div>);
           expect(e.childNodes.length).toBe(3);
           const textNode1 = e.childNodes[0];
           const child = e.childNodes[1];

diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationReconnecting-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationReconnecting-test.js
@@ -310,13 +310,13 @@ describe('ReactDOMServerIntegration', () => {
             <div id="child2" />
           </div>,
           // prettier-ignore
-          <div id="parent"><div id="child1" />      <div id="child2" /></div>, // eslint-disable-line no-multi-spaces
+          <div id="parent"><div id="child1" />      <div id="child2" /></div>,
         ));
 
       it('should error reconnecting a div with children separated by different whitespace on the server', () =>
         expectMarkupMismatch(
           // prettier-ignore
-          <div id="parent"><div id="child1" />      <div id="child2" /></div>, // eslint-disable-line no-multi-spaces
+          <div id="parent"><div id="child1" />      <div id="child2" /></div>,
           <div id="parent">
             <div id="child1" />
             <div id="child2" />
@@ -329,7 +329,7 @@ describe('ReactDOMServerIntegration', () => {
             <div id="child1" /> <div id="child2" />
           </div>,
           // prettier-ignore
-          <div id="parent"><div id="child1" />      <div id="child2" /></div>, // eslint-disable-line no-multi-spaces
+          <div id="parent"><div id="child1" />      <div id="child2" /></div>,
         ));
 
       it('can distinguish an empty component from a dom node', () =>