Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling profiler: Unrecognized event type from Chrome Canary #20767

Closed
bvaughn opened this issue Feb 9, 2021 · 0 comments · Fixed by #20808
Closed

Scheduling profiler: Unrecognized event type from Chrome Canary #20767

bvaughn opened this issue Feb 9, 2021 · 0 comments · Fixed by #20808
Assignees
@bvaughn
Labels
Component: Developer Tools Type: Bug Type: Needs Investigation

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Feb 9, 2021

Importing a profile recorded with Chrome Canary (v90) triggers this error check code:

react/packages/react-devtools-scheduling-profiler/src/import-worker/preprocessData.js

Lines 371 to 378 in 6c526c5

// Unrecognized event
else {
throw new InvalidProfileError(
`Unrecognized event ${JSON.stringify(
event,
)}! This is likely a bug in this profiler tool.`,
);
}

Here's one such example event:

{
  "args": {},
  "cat": "blink.user_timing",
  "name": "requestStart",
  "ph": "I",
  "pid": 64032,
  "s": "t",
  "tid": 775,
  "ts": 25788659448
}

Looks like there's at least one new type, "I", which I assume will eventually affect Chrome stable (currently v88).
@bvaughn bvaughn self-assigned this Feb 9, 2021
bvaughn pushed a commit to bvaughn/react that referenced this issue Feb 23, 2021
Surfaced newly-added lane labels in scheduling profiler UI
3de0bba 
Also fixed a small hiccup caused by Chrome Canary adding an unrecognized profiling event into the data. (This will resolve issue facebook#20767.)
@bvaughn bvaughn mentioned this issue Feb 23, 2021
Merged
bvaughn pushed a commit to bvaughn/react that referenced this issue Feb 23, 2021
Update preprocessor to "support" instant events
8c039ba 
These are no-ops for us, but adding recognition of the event type will prevent profiles imported from e.g. Chrome Canary from thorwing with an "unrecognized event" error. (This will resolve issue facebook#20767.)
bvaughn pushed a commit to bvaughn/react that referenced this issue Feb 23, 2021
Add Lane labels to scheduling profiler marks
6bb6bc6 
This commit changes scheduling profiler marks from a format like '--schedule-render-1' to '--schedule-render-1-Sync' (where 1 is the numeric value of the Sync lane). This will enable the profiler itself to show more meaningful labels for updates and render work.

The commit also refactors and adds additional tests for the sceduling profiler package.

It also updates the preprocessor to 'support' instant events. These are no-ops for us, but adding recognition of the event type will prevent profiles imported from e.g. Chrome Canary from thorwing with an 'unrecognized event' error. (This will resolve issue facebook#20767.)
bvaughn pushed a commit to bvaughn/react that referenced this issue Feb 23, 2021
Add Lane labels to scheduling profiler marks
394bbd4 
This commit changes scheduling profiler marks from a format like '--schedule-render-1' to '--schedule-render-1-Sync' (where 1 is the numeric value of the Sync lane). This will enable the profiler itself to show more meaningful labels for updates and render work.

The commit also refactors and adds additional tests for the sceduling profiler package.

It also updates the preprocessor to 'support' instant events. These are no-ops for us, but adding recognition of the event type will prevent profiles imported from e.g. Chrome Canary from thorwing with an 'unrecognized event' error. (This will resolve issue facebook#20767.)
bvaughn pushed a commit that referenced this issue Feb 23, 2021
Add Lane labels to scheduling profiler marks (#20808)
e5f6b91 
This commit changes scheduling profiler marks from a format like '--schedule-render-1' to '--schedule-render-1-Sync' (where 1 is the numeric value of the Sync lane). This will enable the profiler itself to show more meaningful labels for updates and render work.

The commit also refactors and adds additional tests for the scheduling profiler package.

It also updates the preprocessor to 'support' instant events. These are no-ops for us, but adding recognition of the event type will prevent profiles imported from e.g. Chrome Canary from throwing with an 'unrecognized event' error. (This will resolve issue #20767.)
koto pushed a commit to koto/react that referenced this issue Jun 15, 2021
@koto
Add Lane labels to scheduling profiler marks (facebook#20808)
55aa49e 
This commit changes scheduling profiler marks from a format like '--schedule-render-1' to '--schedule-render-1-Sync' (where 1 is the numeric value of the Sync lane). This will enable the profiler itself to show more meaningful labels for updates and render work.

The commit also refactors and adds additional tests for the scheduling profiler package.

It also updates the preprocessor to 'support' instant events. These are no-ops for us, but adding recognition of the event type will prevent profiles imported from e.g. Chrome Canary from throwing with an 'unrecognized event' error. (This will resolve issue facebook#20767.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
Component: Developer Tools Type: Bug Type: Needs Investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Lane labels to scheduling profiler marks bvaughn/react
1 participant
@bvaughn