Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude src/node_modules from .gitignore. #10028

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

aickin
Copy link
Contributor

@aickin aickin commented Jun 23, 2017

src/node_modules is a directory of package stubs that is checked in for the test suite to use. Unfortunately, though, there is a node_modules line in .gitignore, which means the src/node_modules directory is ignored by git.

I ran into this in #10024, where I had to add a new file to src/node_modules, but because of the .gitignore, I failed to commit the new file. (Obviously, neither git commit -a nor git stage -A will add an ignored file.) My failure to commit the new file lead to a confusing situation where tests were working locally but not in CI, and it took me an hour or two to figure out what was going on.

This PR just excludes src/node_modules from .gitignore so that this kind of thing won't happen again.

Thanks for all your work!

@aickin aickin changed the title Excluding src/node_modules from .gitignore. Exclude src/node_modules from .gitignore. Jun 23, 2017
Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@aickin aickin merged commit a494741 into facebook:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants