Pass pendingProps as argument in createWorkInProgress

[zombieJ]

Update createWorkInProgress in ReactFiber.js to accept pendingProps as argument.

[gaearon]

Here is the callsite that hasn't been updated. It's confusing when functions take different number of arguments in different cases.

What do you think should happen? Should we pass null explicitly?

And why did Flow not catch the missing argument?

[zombieJ]

Hi @gaearon,
Yes. I think it may better if pass null as arguments.
Since react src code is made up of many modules. Function with same args is much eazy for understanding.

And for Flow, I'm not sure why it not catch.

Let me update the pr : )

[gaearon]

I asked @acdlite to look at this when he finds time since it’s his TODO originally.

[acdlite]

We should also update all the places where we mutate pendingProps directly. There are a bunch in ReactChildFiber, like

react/src/renderers/shared/fiber/ReactChildFiber.js

Line 388 in c55ffb3

existing.pendingProps = element.props;

[gaearon]

(In any case let's defer this until after 16)

[acdlite]

Also let's wait until expiration times lands because it will be a pain to resolve the conflicts. #10426

[zombieJ]

Got it. I will update after 16 & #10426

[zombieJ]

@acdlite @gaearon ,
To avoid merge conflict, I open a new PR for this: #11296

Close old one