Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gatsby Docs Update] Error column fixes #10886

Merged
merged 2 commits into from
Sep 27, 2017
Merged

[Gatsby Docs Update] Error column fixes #10886

merged 2 commits into from
Sep 27, 2017

Conversation

joecritch
Copy link
Contributor

@joecritch joecritch commented Sep 27, 2017 •
edited
Loading

  • Change colour of the Error title to be white, instead of the clashing grey.
  • Changed width of the column, to sit well next to the 70% "Live JSX Editor" column
  • Changed the font size & line height of the error column's text to look more readable

cc @bvaughn

screen shot 2017-09-27 at 18 17 45

@joecritch joecritch changed the base branch from master to gatsby September 27, 2017 17:21
@joecritch joecritch changed the title [Gatsby Docs Dpdate] Error column fixes [Gatsby Docs Update] Error column fixes Sep 27, 2017
@reactjs-bot
Copy link

reactjs-bot commented Sep 27, 2017 •
edited
Loading

Deploy preview ready!

Built with commit 4e2cc09

https://deploy-preview-10886--reactjs.netlify.com

bvaughn
bvaughn approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes 👍

@bvaughn bvaughn merged commit 725ce35 into facebook:gatsby Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joecritch @reactjs-bot @bvaughn @facebook-github-bot