Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gatsby] Tightened line heights on paragraphs #10912

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

joecritch
Copy link
Contributor

Tightened line-height on any markdown paragraphs to 1.7, as suggested by @acdlite

Mentioned in #10901

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 2f9fd1e

https://deploy-preview-10912--reactjs.netlify.com

@gaearon gaearon merged commit f49baaa into facebook:gatsby Sep 28, 2017
@gaearon
Copy link
Collaborator

gaearon commented Sep 28, 2017

Nice. Thanks!

@KyleAMathews
Copy link
Contributor

I assume this should be removed as well?

lineHeight: '30px',

Also while nit-picking on design choices ;-) the marginTop on paragraphs feels a bit large now with the reduction of lineHeight.

@acdlite
Copy link
Collaborator

acdlite commented Sep 28, 2017

Thanks @joecritch! I didn't see this PR until just a few moments ago when I visited the docs site and realized it looked much nicer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants