Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call and Return components should use ReactElement #11834

Merged
merged 5 commits into from
Dec 12, 2017
Merged

Call and Return components should use ReactElement #11834

merged 5 commits into from
Dec 12, 2017

Commits on Dec 12, 2017

  1. Call and Return components should use ReactElement 

    ReactChildFiber contains lots of branches that do the same thing for
different child types. We can unify them by having more child types be
ReactElements. This requires that the `type` and `key` fields are
sufficient to determine the identity of the child.

The main benefit is decreased file size, especially as we add more
component types, like context providers and consumers.

This updates Call and Return components to use ReactElement. Portals are
left alone for now because their identity includes the host instance.
    @acdlite
    acdlite committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    7aa0d19 View commit details
    Browse the repository at this point in the history

  2. Move server render invariant for call and return types

    @acdlite
    acdlite committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    04d2358 View commit details
    Browse the repository at this point in the history

  3. Sort ReactElement type checks by most likely

    @acdlite
    acdlite committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    ff70350 View commit details
    Browse the repository at this point in the history

  4. Performance timeline should skip over call components 

    Don't think these were intentionally omitted from the blacklist of
component types.

I went ahead and updated getComponentName to include special types, even
though I don't think they're used anywhere right now.
    @acdlite
    acdlite committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    15ab1fc View commit details
    Browse the repository at this point in the history

  5. Remove surrounding brackets from internal display names

    @acdlite
    acdlite committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    c4a89ae View commit details
    Browse the repository at this point in the history