Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user timing to record the timeout deadline with 'waiting' events #12479

Merged
merged 3 commits into from
Mar 29, 2018
Merged

Update user timing to record the timeout deadline with 'waiting' events #12479

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f996b92
Update user timing to record the timeout deadline with 'waiting' events
flarnie Mar 28, 2018
430de07
Improve wording of message
flarnie Mar 29, 2018
f065c9e
ran prettier
flarnie Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ran prettier
  • Loading branch information
@flarnie
flarnie committed Mar 29, 2018
commit f065c9e199ccfdacb09357af432830c0b97bee68
9 changes: 7 additions & 2 deletions packages/react-reconciler/src/ReactDebugFiberPerf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,13 +248,18 @@ export function startRequestCallbackTimer(): void {
}
}

export function stopRequestCallbackTimer(didExpire: boolean, expirationTime: number): void {
export function stopRequestCallbackTimer(
didExpire: boolean,
expirationTime: number,
): void {
if (enableUserTimingAPI) {
if (supportsUserTiming) {
isWaitingForCallback = false;
const warning = didExpire ? 'React was blocked by main thread' : null;
endMark(
`(Waiting for async callback... will force flush in ${expirationTime} ms)`,
`(Waiting for async callback... will force flush in ${
expirationTime
} ms)`,
'(Waiting for async callback...)',
warning,
);
Expand Down