Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra typeof checks for contextType.unstable_read #13736

Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 26, 2018

Follow up to feedback from @sebmarkbage on PR #13728. We still provide a helpful DEV mode warning, but we throw instead of gracefully degrading in the case of an invalid contextType value.

@sizebot
Copy link

sizebot commented Sep 26, 2018

Details of bundled changes.

Comparing: 0dc0ddc...a0efc23

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@bvaughn bvaughn merged commit c521264 into facebook:master Sep 28, 2018
@bvaughn bvaughn deleted the contextType-remove-extra-type-check branch September 28, 2018 20:12
acdlite pushed a commit to plievone/react that referenced this pull request Oct 5, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants