Event API: ensure we pop context for event system fibers #15599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necolas
approved these changes
May 9, 2019
|
I will add some tests in a follow up. Landing to unblock internal issues. |
|
To find what breaks, you can comment out other lines in this function, see which existing tests break, and write similar tests. Unwinding is used for Suspense and/or error handling afaik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I stumbled across when running this internally. I'm not sure how to repro this in a test, as I don't know what conditions are needed exactly with the test renderer to invoke the
unwindInterruptedWorkfunction. Will follow up with someone to figure one out.