[Flight] Better compat with http.createServer #17289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c36a1b3:
|
Size changes (stable)ReactDOM: size: 0.0%, gzip: -0.2% Details of bundled changes.Comparing: 62ef250...c36a1b3 react-dom
|
Size changes (experimental)ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: 62ef250...c36a1b3 react-dom
|
sebmarkbage
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Seems unfortunate to do these checks in the hot path but ok for now I guess.
I also wonder if the HTTP server always flushes at the end of the tick or what it does for buffering.
Would be bad if it waits for a few bytes that takes long to load before flushing the previous pieces.
|
I guess we'll see what objects returned by Express etc are like. Maybe they shield from this and we won't need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if we care in longer term but I use
http.createServerfor testing and that has older Node streams. They don't havecorkanduncork. Also theflushon that object was misleading (because it was only used for flushing headers) so it fires a deprecation warning.That's a few workarounds to make it work with
http.createServer. Maybe we'll remove it later but that's the most convincing way to "really" test it that I found so far.