Use Closure Compiler to compile to ES5 instead of Babel #18449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
requested review from
threepointone,
bvaughn,
necolas,
gaearon,
trueadm,
lunaruan and
acdlite
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
closurees2015
branch
from
be6aa3e
to
6fc2e25
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2979cee:
|
Details of bundled changes.Comparing: 9b88b78...2979cee react-dom
react-flight-dom-webpack
react-test-renderer
react-native-renderer
react-flight-dom-relay
react-refresh
react-art
react-server
react-is
jest-react
react-noop-renderer
react-reconciler
react-client
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
Details of bundled changes.Comparing: 9b88b78...2979cee react-dom
react-flight-dom-webpack
react-test-renderer
react-flight-dom-relay
react-refresh
react-art
react-native-renderer
react-noop-renderer
react-server
react-is
react-reconciler
jest-react
react-client
ReactDOM: size: -0.5%, gzip: 🔺+0.2% Size changes (experimental) |
trueadm
approved these changes
Apr 1, 2020
There are newer versions but they don't yet have corresponding releases of google-closure-compiler-osx.
Provides a little better output.
sebmarkbage
force-pushed
the
closurees2015
branch
from
6fc2e25
to
2979cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to do some static compilation refactoring, I noticed that Closure Compiler uses particularly
letvsconstto do optimization. We're better off leaving the code as ES2015 and letting Closure Compiler compile it down to ES5.Unfortunately it tries to also compile calls to native functions to runtime polyfills. There's an option to opt out of that but it has a bug with Symbols. I had to work around Symbols a bit. We'll have to be careful with that as we add new ES2015 library calls (Object.assign and Array.from seems fine).
I also used a different Babel config for builds than the general project one which is also used for running tests. We should try to keep this config limited.
Maybe one day we can skip Babel all together.
Diff of the build output. sebmarkbage/react-builds@a63c7ee