Upgrade fbjs-scripts #18684
Merged
Upgrade fbjs-scripts #18684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script takes into account the NODE_ENV as part of jest cache keys. This avoids flaky tests since we depend on different transforms in prod and dev.
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Apr 21, 2020
| @@ -2430,104 +2618,6 @@ babel-eslint@^9.0.0: | |||
| eslint-scope "3.7.1" | |||
| eslint-visitor-keys "^1.0.0" | |||
|
|
|||
| babel-generator@^6.26.0: | |||
There was a problem hiding this comment.
lol. Don't need these anymore.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f4bea8:
|
sebmarkbage
commented
Apr 21, 2020
| @@ -415,7 +415,7 @@ describe('ReactFreshBabelPlugin', () => { | |||
| } | |||
| `, | |||
| { | |||
| plugins: ['transform-es2015-modules-commonjs'], | |||
There was a problem hiding this comment.
@gaearon This is the Babel 6 version which was only accidentally available in our repo. This now uses the Babel 7 transform. Not sure what this is testing.
There was a problem hiding this comment.
I think this just makes sure the transform doesn't break it in some way. Makes sense to use the recent one.
acdlite
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version takes into account the NODE_ENV as part of jest cache keys. This avoids flaky tests since we depend on different transforms in prod and dev.