Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump ESLint version to v7 #18897

Merged
merged 1 commit into from
May 12, 2020
Merged

deps: bump ESLint version to v7 #18897

merged 1 commit into from
May 12, 2020

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented May 12, 2020

Summary

This PR is to update ESLint version in devDependencies to v7.
The motivation is to verify whether eslint-plugin-react-hooks works fine with ESLint v7.
#18878 is a PR to bump the peerDependencies version, but it doesn't guarantee the behavior with ESLint v7.

I've also fixed some failed tests with ESLint v7.
The fails are caused by eslint/eslint#12955, which makes output require when the rule has fixed the code.

Test Plan

yarn test && yarn lint

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 648124e:

Sandbox Source
jolly-dan-4xfyd Configuration

@koba04
Copy link
Contributor Author

koba04 commented May 12, 2020

All checks have passed🚀

@gaearon gaearon merged commit 039ad34 into facebook:master May 12, 2020
@gaearon
Copy link
Collaborator

gaearon commented May 12, 2020

thank you

@trueadm
Copy link
Contributor

trueadm commented May 12, 2020

This is now causing master to fail because during our validation script we get the error:

No files matching the pattern "./build/node_modules/*/umd/*.js" were found.

Oddly, there are definitely files in there, as it states this just above.

Checking if files exist in ./build/node_modules/*/umd/*.js...
Found 32 bundles.

Any ideas?

gaearon added a commit that referenced this pull request May 12, 2020
gaearon added a commit that referenced this pull request May 12, 2020
@gaearon
Copy link
Collaborator

gaearon commented May 12, 2020

I reverted in #18899 because this failed master builds. It seems like we only ran this task on master? @koba04 mind looking into this?

@koba04
Copy link
Contributor Author

koba04 commented May 12, 2020

@gaearon oh, I’ll work on it now!

koba04 added a commit to koba04/react that referenced this pull request May 12, 2020
@koba04
Copy link
Contributor Author

koba04 commented May 13, 2020

@gaearon @trueadm I've fixed it at #18900.

@koba04 koba04 deleted the eslint-v7 branch May 13, 2020 00:04
koba04 added a commit to koba04/react that referenced this pull request May 15, 2020
gaearon pushed a commit that referenced this pull request May 27, 2020
* Revert "Revert "deps: update ESLint version to v7 (#18897)" (#18899)"

This reverts commit 84fd4b8.

* fix rollup validate script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants