Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused argument from finishConcurrentRender #19689

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Remove unused argument from finishConcurrentRender #19689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unused argument from finishConcurrentRender
  • Loading branch information
@inottn
inottn committed Aug 25, 2020
commit 35ee1cf8d36e14395f75ec1b1cba491a6de47338
4 changes: 2 additions & 2 deletions packages/react-reconciler/src/ReactFiberWorkLoop.new.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ function performConcurrentWorkOnRoot(root) {
const finishedWork: Fiber = (root.current.alternate: any);
root.finishedWork = finishedWork;
root.finishedLanes = lanes;
finishConcurrentRender(root, finishedWork, exitStatus, lanes);
finishConcurrentRender(root, exitStatus, lanes);
}

ensureRootIsScheduled(root, now());
Expand All @@ -871,7 +871,7 @@ function performConcurrentWorkOnRoot(root) {
return null;
}

function finishConcurrentRender(root, finishedWork, exitStatus, lanes) {
function finishConcurrentRender(root, exitStatus, lanes) {
switch (exitStatus) {
case RootIncomplete:
case RootFatalErrored: {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-reconciler/src/ReactFiberWorkLoop.old.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ function performConcurrentWorkOnRoot(root) {
const finishedWork: Fiber = (root.current.alternate: any);
root.finishedWork = finishedWork;
root.finishedLanes = lanes;
finishConcurrentRender(root, finishedWork, exitStatus, lanes);
finishConcurrentRender(root, exitStatus, lanes);
}

ensureRootIsScheduled(root, now());
Expand All @@ -859,7 +859,7 @@ function performConcurrentWorkOnRoot(root) {
return null;
}

function finishConcurrentRender(root, finishedWork, exitStatus, lanes) {
function finishConcurrentRender(root, exitStatus, lanes) {
switch (exitStatus) {
case RootIncomplete:
case RootFatalErrored: {
Expand Down