[Fizz] Wire up the Fixture #21273
Merged
[Fizz] Wire up the Fixture #21273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Apr 14, 2021
| @@ -892,7 +892,7 @@ export function commitHydratedSuspenseInstance( | |||
| export function shouldDeleteUnhydratedTailInstances( | |||
| parentType: string, | |||
| ): boolean { | |||
| return parentType !== 'head' || parentType !== 'body'; | |||
| return parentType !== 'head' && parentType !== 'body'; | |||
There was a problem hiding this comment.
This case is most for this case of hydrating the whole doc which doesn't have other test coverage. Made a typo in the refactor before.
There was a problem hiding this comment.
@acdlite This affects the reconciler.
| if (typeof children === 'string') { | ||
| // Special case children as a string to avoid the unnecessary comment. | ||
| // TODO: Remove this special case after the general optimization is in place. | ||
| target.push(stringToChunk(children)); |
There was a problem hiding this comment.
Needed this to avoid emitting the extra comment in the <title> tag.
| @@ -10,23 +10,29 @@ function LoadingIndicator() { | |||
| return <div className={theme + '-loading'}>Loading...</div>; | |||
| } | |||
|
|
|||
| export default function App({assets}) { | |||
| function Content() { | |||
There was a problem hiding this comment.
I extracted this so that you can add a throw in this to test the error behavior. You can't throw in App because there's no Suspense around it.
sebmarkbage
force-pushed
the
fizzfixture
branch
from
fa800f0
to
295d168
Compare
gaearon
approved these changes
Apr 14, 2021
sebmarkbage
force-pushed
the
fizzfixture
branch
from
295d168
to
3744ae5
Compare
|
Comparing: 11b0759...04cd737 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
force-pushed
the
fizzfixture
branch
from
3744ae5
to
04cd737
Compare
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Wire up fizz to fixture * Fixed typo conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now far enough along in parity to run the fixture.