Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic flags to React Native #21291

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Add dynamic flags to React Native #21291

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35d464
Add dynamic flags to React Native
rickhanlonii Apr 15, 2021
9aff2c4
Hardcode the setting to false instead
rickhanlonii Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Hardcode the setting to false instead
  • Loading branch information
@rickhanlonii
rickhanlonii committed Apr 15, 2021
commit 9aff2c4f4109bada14a3f16a02e3fd02f448f91e
6 changes: 1 addition & 5 deletions packages/shared/forks/ReactFeatureFlags.native-fb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@

import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
import typeof * as ExportsType from './ReactFeatureFlags.native-fb';
import * as DynamicFeatureFlags from './ReactFeatureFlags.www-dynamic';

// Re-export dynamic flags.
const dynamicFeatureFlags: DynamicFeatureFlags = require('ReactFeatureFlags');
export const {enableSyncDefaultUpdates} = dynamicFeatureFlags;

// The rest of the flags are static for better dead code elimination.
export const enableDebugTracing = false;
Expand Down Expand Up @@ -65,6 +60,7 @@ export const enableUseRefAccessWarning = false;
export const enableRecursiveCommitTraversal = false;
export const disableSchedulerTimeoutInWorkLoop = false;
export const enableLazyContextPropagation = false;
export const enableSyncDefaultUpdates = false;

// Flow magic to verify the exports of this file match the original version.
// eslint-disable-next-line no-unused-vars
Expand Down