Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usereducer eager bailout #22445

Merged
merged 10 commits into from
Sep 27, 2021
Merged

Remove usereducer eager bailout #22445

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
11a379a
Fork dispatchAction for useState/useReducer
josephsavona Sep 27, 2021
27048d2
Remove eager bailout from forked dispatchReducerAction, update tests
josephsavona Sep 27, 2021
882bbad
Update eager reducer/state logic to handle state case only
josephsavona Sep 27, 2021
e49a79a
sync reconciler fork
josephsavona Sep 27, 2021
bf21962
rename test
josephsavona Sep 27, 2021
c01afe4
test cases from #15198
josephsavona Sep 27, 2021
b6cabe8
comments on new test cases
josephsavona Sep 27, 2021
895e2a7
comments on new test cases
josephsavona Sep 27, 2021
1e621bf
test case from #21419
josephsavona Sep 27, 2021
432cf94
minor tweak to test name to kick CI
josephsavona Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename test
  • Loading branch information
@josephsavona
josephsavona committed Sep 27, 2021
commit bf219621ca274800cb295f5c3c9b921c5aada4a1
4 changes: 1 addition & 3 deletions packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3867,9 +3867,7 @@ describe('ReactHooksWithNoopRenderer', () => {
});
});

// TODO: delete now that we removed the eager bailout optimization? or do we want to keep this
// around in some capacity?
it('eager bailout optimization should always compare to latest rendered reducer', () => {
it('useReducer does not eagerly bail out of state updates', () => {
// Edge case based on a bug report
let setCounter;
function App() {
Expand Down