Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync hydrate discrete events in capture phase and dont replay discrete events #22448

Merged
merged 27 commits into from
Oct 4, 2021
Merged

Sync hydrate discrete events in capture phase and dont replay discrete events #22448

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
546ab4c
synchronously hydrate discrete events in capture phase and dont repla…
salazarm Sep 27, 2021
7aeaeb5
test??
salazarm Sep 27, 2021
89572cb
replace old with new
salazarm Sep 27, 2021
3e10694
prettier
salazarm Sep 27, 2021
1307b90
update test
salazarm Sep 29, 2021
f5ff2fd
remove unused var
salazarm Sep 29, 2021
b98f04b
gate changes
salazarm Oct 1, 2021
1bb0537
lint
salazarm Oct 1, 2021
a5e8a2b
fix test
salazarm Oct 1, 2021
f92b36d
only gate small parts of some tests
salazarm Oct 1, 2021
714509b
use gate function in tests instead
salazarm Oct 1, 2021
351c238
synchronously hydrate discrete events in capture phase and dont repla…
salazarm Sep 27, 2021
eec367a
test??
salazarm Sep 27, 2021
fa54529
replace old with new
salazarm Sep 27, 2021
567d8dd
prettier
salazarm Sep 27, 2021
53c0a6e
update test
salazarm Sep 29, 2021
ebf975c
remove unused var
salazarm Sep 29, 2021
c86a63a
gate changes
salazarm Oct 1, 2021
8e49d11
lint
salazarm Oct 1, 2021
b23468e
fix test
salazarm Oct 1, 2021
c042e6e
only gate small parts of some tests
salazarm Oct 1, 2021
ab9a113
use gate function in tests instead
salazarm Oct 1, 2021
e2a929b
incorporate feedback and fix bug affecting continuous events
salazarm Oct 4, 2021
69a72fb
merge?
salazarm Oct 4, 2021
19a1520
remove redudant test
salazarm Oct 4, 2021
b1c9e62
remote gating from bad merge
salazarm Oct 4, 2021
c10215e
and couple more changes wipe out from rebase/pull o.O
salazarm Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use gate function in tests instead
  • Loading branch information
@salazarm
salazarm committed Oct 1, 2021
commit 714509b20f3f3ed8e4eb9601d0715f24a9f31d87
35 changes: 28 additions & 7 deletions packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,7 +1907,10 @@ describe('ReactDOMServerPartialHydration', () => {
});

if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
expect(clicks).toBe(0);
expect(container.textContent).toBe('Click meHello');
Expand Down Expand Up @@ -1998,7 +2001,10 @@ describe('ReactDOMServerPartialHydration', () => {
});

if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
expect(onEvent).toHaveBeenCalledTimes(0);
} else {
Expand Down Expand Up @@ -2086,7 +2092,10 @@ describe('ReactDOMServerPartialHydration', () => {
});

if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
expect(clicks).toBe(0);
} else {
Expand Down Expand Up @@ -2178,7 +2187,10 @@ describe('ReactDOMServerPartialHydration', () => {
await promise;
});
if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
expect(onEvent).toHaveBeenCalledTimes(0);
} else {
Expand Down Expand Up @@ -2257,7 +2269,10 @@ describe('ReactDOMServerPartialHydration', () => {
});

if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
expect(clicksOnChild).toBe(0);
expect(clicksOnParent).toBe(0);
Expand Down Expand Up @@ -2343,7 +2358,10 @@ describe('ReactDOMServerPartialHydration', () => {

// We're now full hydrated.
if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
expect(clicks).toBe(0);
} else {
Expand Down Expand Up @@ -2619,7 +2637,10 @@ describe('ReactDOMServerPartialHydration', () => {
});

if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
// discrete event not replayed
expect(submits).toBe(0);
Expand Down
5 changes: 4 additions & 1 deletion packages/react-dom/src/events/__tests__/DOMPluginEventSystem-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,10 @@ describe('DOMPluginEventSystem', () => {
// We're now full hydrated.

if (
ReactFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
gate(
flags =>
flags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
)
) {
expect(clicks).toBe(0);
} else {
Expand Down