Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude react-dom/unstable_testing entry point from stable releases #23258

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Exclude react-dom/unstable_testing entry point from stable releases #23258

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aced076
Use consistent naming for unstable_testing entry point
sebmarkbage Feb 9, 2022
17bcd78
Exclude the testing build from non-experimental builds except at FB
sebmarkbage Feb 9, 2022
613900b
FB builds shouldn't contribute to whether we include the npm files
sebmarkbage Feb 9, 2022
9a4d8a2
Exclude exports fields if we delete the files entry
sebmarkbage Feb 9, 2022
40cecfd
Move test to no longer be internal so we can test against the build
sebmarkbage Feb 9, 2022
073eea3
Update the bundle artifact names since they've now changed
sebmarkbage Feb 9, 2022
157cab1
Gate import since it doesn't exist
sebmarkbage Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Exclude the testing build from non-experimental builds except at FB
  • Loading branch information
@sebmarkbage
sebmarkbage committed Feb 9, 2022
commit 17bcd78f6be05f012b6851083e2acad4720666fe
7 changes: 4 additions & 3 deletions scripts/rollup/bundles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,13 @@ const bundles = [
externals: ['react', 'react-dom'],
},

// TODO: We don't use this bundle anymore
/******* React DOM - www - Testing *******/
{
moduleType: RENDERER,
bundleTypes: [FB_WWW_DEV, FB_WWW_PROD, NODE_DEV, NODE_PROD],
entry: 'react-dom/testing',
bundleTypes: __EXPERIMENTAL__
? [FB_WWW_DEV, FB_WWW_PROD, NODE_DEV, NODE_PROD]
: [FB_WWW_DEV, FB_WWW_PROD],
entry: 'react-dom/unstable_testing',
global: 'ReactDOMTesting',
minifyWithProdErrorCodes: true,
wrapWithModuleBoundaries: false,
Expand Down