Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not replay erroring beginWork with invokeGuardedCallback when suspended or previously errored #24480

Merged
merged 1 commit into from
May 3, 2022
Merged

Do not replay erroring beginWork with invokeGuardedCallback when suspended or previously errored #24480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not replay erroring beginWork with invokeGuardedCallback when susp… 
…ended or previously errored

When hydrating a suspense boundary an error or a suspending fiber can often lead to a cascade of hydration errors. While in many cases these errors are simply discarded (e.g. when teh root does not commit and we fall back to client rendering) the use of invokeGuardedCallback can lead to many of these errors appearing as uncaught in the browser console. This change avoids error replaying using invokeGuardedCallback when we are hydrating a suspense boundary and have either already suspended or we have one previous error which was replayed.
  • Loading branch information
@gnoff
gnoff committed May 3, 2022
commit 710429e5aab0c3c9326f141e1cf47ae7ce6f440f
Loading