Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove argument committedLanes from reappearLayoutEffects #25080

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Remove argument committedLanes from reappearLayoutEffects #25080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/react-reconciler/src/ReactFiberCommitWork.new.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
} else {
Expand Down Expand Up @@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
finishedRoot: FiberRoot,
current: Fiber | null,
finishedWork: Fiber,
committedLanes: Lanes,
// This function visits both newly finished work and nodes that were re-used
// from a previously committed tree. We cannot check non-static flags if the
// node was reused.
Expand All @@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Check flags & LayoutStatic
Expand All @@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand Down Expand Up @@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Figure out how Profiler updates should work with Offscreen
Expand All @@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
}
Expand All @@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
break;
Expand All @@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
function recursivelyTraverseReappearLayoutEffects(
finishedRoot: FiberRoot,
parentFiber: Fiber,
committedLanes: Lanes,
includeWorkInProgressEffects: boolean,
) {
// This function visits both newly finished work and nodes that were re-used
Expand All @@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
finishedRoot,
current,
child,
committedLanes,
childShouldIncludeWorkInProgressEffects,
);
child = child.sibling;
Expand Down
11 changes: 0 additions & 11 deletions packages/react-reconciler/src/ReactFiberCommitWork.old.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
} else {
Expand Down Expand Up @@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
finishedRoot: FiberRoot,
current: Fiber | null,
finishedWork: Fiber,
committedLanes: Lanes,
// This function visits both newly finished work and nodes that were re-used
// from a previously committed tree. We cannot check non-static flags if the
// node was reused.
Expand All @@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Check flags & LayoutStatic
Expand All @@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand Down Expand Up @@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Figure out how Profiler updates should work with Offscreen
Expand All @@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
}
Expand All @@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
break;
Expand All @@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
function recursivelyTraverseReappearLayoutEffects(
finishedRoot: FiberRoot,
parentFiber: Fiber,
committedLanes: Lanes,
includeWorkInProgressEffects: boolean,
) {
// This function visits both newly finished work and nodes that were re-used
Expand All @@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
finishedRoot,
current,
child,
committedLanes,
childShouldIncludeWorkInProgressEffects,
);
child = child.sibling;
Expand Down