Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit th headers attribute #2553

Merged
merged 1 commit into from
Nov 26, 2014
Merged

Conversation

mhuggins
Copy link
Contributor

Permits the headers attribute as defined by the W3C. Resolves #2516.

@zpao
Copy link
Member

zpao commented Nov 19, 2014

👍 Can you remove the commit with the documentation update? We'll take care of that when we do the release (this makes it easier to cherry pick into stable branches)

@zpao
Copy link
Member

zpao commented Nov 19, 2014

Oh also, did you test that node.headers = value works and we don't need to use node.setAttribute?

@syranide
Copy link
Contributor

@zpao I confirm that .headers exist on IE8.

@mhuggins
Copy link
Contributor Author

@zpao I just removed the doc commit, so it's simply the headers attribute change now. When you ask about testing node.headers = value vs. setAttribute, that's not something I looked into, but it sounds like @syranide answered that question. Moving forward for changes like these, it sounds like I just need to see if altering the attribute value via property vs. setAttribute is just something to manually smoke check across browsers?

@zpao
Copy link
Member

zpao commented Nov 26, 2014

@mhuggins yea, we just manual test it for now because behavior hasn't been consistent. We may make this better in the future.

Thanks btw!

zpao added a commit that referenced this pull request Nov 26, 2014
@zpao zpao merged commit 45a19a2 into facebook:master Nov 26, 2014
@mhuggins mhuggins deleted the headers-attribute branch February 23, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables w/ "headers" attribute
3 participants