Replace mountDepth with isTopLevel
#2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: After facebook#2570, `mountDepth` is only used to enforce that `setProps` and `replaceProps` is only invoked on the top-level component. This replaces `mountDepth` with a simpler `isTopLevel` boolean set by `ReactMount` which reduces the surface area of the internal API and removes the need to thread `mountDepth` throughout React core. Reviewers: @sebmarkbage @zpao Test Plan: Ran unit tests successfully: ``` npm run jest ```
| @@ -225,7 +225,8 @@ function mountComponentIntoNode( | |||
| container, | |||
| transaction, | |||
| shouldReuseMarkup) { | |||
| var markup = this.mountComponent(rootID, transaction, 0, emptyObject); | |||
| var markup = this.mountComponent(rootID, transaction, emptyObject); | |||
| this._isTopLevel = true; | |||
There was a problem hiding this comment.
Is it safe here to assume that this is going to be a ReactCompositeComponent?
Edit: Otherwise, preventExtension will complain. 👎
There was a problem hiding this comment.
Yea, it's because the callback is used with a "context". Annoying OO pattern.
Edit: This will probably change but it's currently true.
yungsters
added a commit
that referenced
this pull request
Nov 19, 2014
Replace `mountDepth` with `isTopLevel`
This was referenced Apr 29, 2020
This was referenced Jul 28, 2020
This was referenced May 5, 2021
This was referenced Jan 16, 2022
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After #2570,
mountDepthis only used to enforce thatsetPropsandreplacePropsis only invoked on the top-level component. This replacesmountDepthwith a simpler
isTopLevelboolean set byReactMountwhich reduces the surface area of the internal API and removes the need to threadmountDepththroughout React core.Reviewers: @sebmarkbage @zpao
Test Plan:
Ran unit tests successfully: