Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export dynamic disableSchedulerTimeoutInWorkLoop flag in www #27117

Merged

Conversation

noahlemen
Copy link
Member

Summary

This was not exposed as a dynamic flag in the build for facebook www. By adding it, we'll be able to roll this out incrementally before cleaning up this code altogether.

How did you test this change?

yarn build

Before changes, disableSchedulerTimeoutInWorkLoop flag is not included in ReactDOM-* build output for facebook www. Afterwards, it is included.

@react-sizebot
Copy link

Comparing: fdc8c81...9d9a241

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.35 kB 164.35 kB = 51.76 kB 51.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.76 kB 171.76 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js +0.02% 567.22 kB 567.36 kB +0.04% 100.04 kB 100.08 kB
facebook-www/ReactDOM-prod.modern.js +0.02% 551.02 kB 551.15 kB +0.05% 97.21 kB 97.25 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9d9a241

@noahlemen noahlemen merged commit 9f4fbec into facebook:main Jul 17, 2023
2 checks passed
@noahlemen noahlemen deleted the noahlemen-dynamic-scheduler-timeout-flag branch July 17, 2023 19:45
github-actions bot pushed a commit that referenced this pull request Jul 17, 2023
## Summary

This was not exposed as a dynamic flag in the build for facebook www. By
adding it, we'll be able to roll this out incrementally before cleaning
up this code altogether.

## How did you test this change?

`yarn build`

Before changes, `disableSchedulerTimeoutInWorkLoop` flag is not included
in ReactDOM-* build output for facebook www. Afterwards, it is included.

DiffTrain build for [9f4fbec](9f4fbec)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…k#27117)

## Summary

This was not exposed as a dynamic flag in the build for facebook www. By
adding it, we'll be able to roll this out incrementally before cleaning
up this code altogether.

## How did you test this change?

`yarn build`

Before changes, `disableSchedulerTimeoutInWorkLoop` flag is not included
in ReactDOM-* build output for facebook www. Afterwards, it is included.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
## Summary

This was not exposed as a dynamic flag in the build for facebook www. By
adding it, we'll be able to roll this out incrementally before cleaning
up this code altogether.

## How did you test this change?

`yarn build`

Before changes, `disableSchedulerTimeoutInWorkLoop` flag is not included
in ReactDOM-* build output for facebook www. Afterwards, it is included.

DiffTrain build for commit 9f4fbec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants