Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz] Split createRequest into createRequest, createPrerenderRequest and resumeRequest #27342

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

sebmarkbage
Copy link
Collaborator

Just moving some internal code around again.

I originally encoded what type of work using startRender vs startPrerender. I had intended to do more forking of the work loop but we've decided not to go with that strategy. It also turns out that forking when we start working is actually too late because of a subtle thing where you can call abort before work begins. Therefore it's important that starting the work comes later.

This split isn't going to work after all. Need to be at the create layer.
…sumeRequest

This is what encodes what type of work we'll do.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 7, 2023
@react-sizebot
Copy link

Comparing: ee7f9c9...c4459cb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 165.63 kB 165.63 kB = 51.88 kB 51.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 174.70 kB 174.70 kB = 54.61 kB 54.61 kB
facebook-www/ReactDOM-prod.classic.js = 570.44 kB 570.44 kB = 100.45 kB 100.45 kB
facebook-www/ReactDOM-prod.modern.js = 554.21 kB 554.21 kB = 97.61 kB 97.61 kB
oss-stable-semver/react-server/cjs/react-server.production.min.js +3.20% 25.91 kB 26.74 kB +1.54% 8.78 kB 8.92 kB
oss-stable/react-server/cjs/react-server.production.min.js +3.20% 25.91 kB 26.74 kB +1.54% 8.78 kB 8.92 kB
oss-experimental/react-server/cjs/react-server.production.min.js +2.96% 27.99 kB 28.82 kB +1.43% 9.39 kB 9.52 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server/cjs/react-server.production.min.js +3.20% 25.91 kB 26.74 kB +1.54% 8.78 kB 8.92 kB
oss-stable/react-server/cjs/react-server.production.min.js +3.20% 25.91 kB 26.74 kB +1.54% 8.78 kB 8.92 kB
oss-experimental/react-server/cjs/react-server.production.min.js +2.96% 27.99 kB 28.82 kB +1.43% 9.39 kB 9.52 kB
oss-stable-semver/react-server/cjs/react-server.development.js +1.43% 150.33 kB 152.48 kB +0.32% 37.43 kB 37.55 kB
oss-stable/react-server/cjs/react-server.development.js +1.43% 150.33 kB 152.48 kB +0.32% 37.43 kB 37.55 kB
oss-experimental/react-server/cjs/react-server.development.js +1.33% 161.31 kB 163.46 kB +0.36% 40.12 kB 40.26 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js +1.14% 68.21 kB 68.99 kB +0.55% 20.89 kB 21.00 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js +1.14% 68.34 kB 69.12 kB +0.53% 21.16 kB 21.27 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.min.js +1.07% 72.67 kB 73.45 kB +0.57% 22.38 kB 22.51 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js +1.00% 72.99 kB 73.72 kB +0.57% 22.56 kB 22.69 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.55% 369.45 kB 371.47 kB +0.15% 82.39 kB 82.52 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js +0.55% 369.86 kB 371.88 kB +0.15% 82.51 kB 82.64 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.54% 370.75 kB 372.76 kB +0.14% 82.71 kB 82.83 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js +0.54% 387.07 kB 389.16 kB +0.17% 83.28 kB 83.42 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js = 1.31 kB 1.30 kB = 0.62 kB 0.62 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js = 1.31 kB 1.30 kB = 0.62 kB 0.62 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js = 1.31 kB 1.30 kB = 0.62 kB 0.62 kB

Generated by 🚫 dangerJS against c4459cb

@sebmarkbage sebmarkbage merged commit 953cb02 into facebook:main Sep 7, 2023
36 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
… and resumeRequest (#27342)

Just moving some internal code around again.

I originally encoded what type of work using startRender vs
startPrerender. I had intended to do more forking of the work loop but
we've decided not to go with that strategy. It also turns out that
forking when we start working is actually too late because of a subtle
thing where you can call abort before work begins. Therefore it's
important that starting the work comes later.

DiffTrain build for [953cb02](953cb02)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
… and resumeRequest (facebook#27342)

Just moving some internal code around again.

I originally encoded what type of work using startRender vs
startPrerender. I had intended to do more forking of the work loop but
we've decided not to go with that strategy. It also turns out that
forking when we start working is actually too late because of a subtle
thing where you can call abort before work begins. Therefore it's
important that starting the work comes later.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
… and resumeRequest (#27342)

Just moving some internal code around again.

I originally encoded what type of work using startRender vs
startPrerender. I had intended to do more forking of the work loop but
we've decided not to go with that strategy. It also turns out that
forking when we start working is actually too late because of a subtle
thing where you can call abort before work begins. Therefore it's
important that starting the work comes later.

DiffTrain build for commit 953cb02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants