Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint-plugin-react-hooks: Add support for ESLint v9 #28773

Merged
merged 6 commits into from
Apr 23, 2024
+618 −91
Merged

eslint-plugin-react-hooks: Add support for ESLint v9 #28773

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8590c49
Install ESLint v9
eps1lon Apr 22, 2024
8fdfca7
eslint-plugin-react-hooks: Add support for ESLint v9
eps1lon Apr 6, 2024
775bd6c
Can't support earlier ESLint versions without forking
eps1lon Apr 6, 2024
31ba7bf
No breaking changes
eps1lon Apr 6, 2024
5d30424
fork impl instead of checking an invariant every call
eps1lon Apr 12, 2024
c1f1de3
Update packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaust…
eps1lon Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaust… 
…iveDeps-test.js

Co-authored-by: lauren <poteto@users.noreply.github.com>
  • Loading branch information
@eps1lon @poteto
eps1lon and poteto committed Apr 22, 2024
commit c1f1de30079458a07e3d397ae81d36f4f7ffefbe
2 changes: 1 addition & 1 deletion packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8276,7 +8276,7 @@ describe('rules-of-hooks/exhaustive-deps', () => {
parser: require.resolve('@typescript-eslint/parser-v2'),
parserOptions: parserOptionsV7,
}).run(
'eslint: v9, parser: @typescript-eslint/parser@2.x',
'eslint: v7, parser: @typescript-eslint/parser@2.x',
ReactHooksESLintRule,
testsTypescriptEslintParser
);
Expand Down