Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flight-browser fixture #28828

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 11, 2024

The flight-browser fixtures doesn't make sense. It also uses UMD builds which are being removed so we'd have to make it use esm.sh or something and really it just won't work because it needs to be built by webpack to not error. We could potentially shim the webpack globals but really the right thing is to publish the esm version of react-server and use esm.sh to load a browser only esm demo of react-server. This change removes the flight-browser fixture

…ds which are now removed so we'd have to make it use esm.sh or something and really it just won't work because it needs to be built by webpack to not error. We could potentially shim the webpack globals but really the right thing is to publish the esm version of react-server and use esm.sh to load a browser only esm demo of react-server. This change removes the flight-browser fixtures
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 11, 2024
@react-sizebot
Copy link

Comparing: c8a0350...386ffb3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.76 kB 168.76 kB = 52.91 kB 52.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.57 kB 170.57 kB = 53.44 kB 53.44 kB
facebook-www/ReactDOM-prod.classic.js = 590.84 kB 590.84 kB = 103.91 kB 103.91 kB
facebook-www/ReactDOM-prod.modern.js = 566.66 kB 566.66 kB = 100.10 kB 100.10 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Generated by 🚫 dangerJS against 386ffb3

@gnoff gnoff merged commit ba1a979 into facebook:main Apr 12, 2024
38 checks passed
@gnoff gnoff deleted the remove-flight-browser-fixtures branch April 12, 2024 16:48
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
The flight-browser fixtures doesn't make sense. It also uses UMD builds
which are being removed so we'd have to make it use esm.sh or something
and really it just won't work because it needs to be built by webpack to
not error. We could potentially shim the webpack globals but really the
right thing is to publish the esm version of react-server and use esm.sh
to load a browser only esm demo of react-server. This change removes the
flight-browser fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants