Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Allow String Chunks to Passthrough in Node streams and renderToMarkup #30131

Merged
merged 3 commits into from
Jul 3, 2024
Merged

[Flight] Allow String Chunks to Passthrough in Node streams and renderToMarkup #30131

merged 3 commits into from
Jul 3, 2024
+186 −25

Commits on Jun 28, 2024

  1. Allow Flight Client to be implemented by parsing pass-through string … 

    …chunks

It can be efficient to accept raw string chunks to pass through a stream
instead of encoding them into a binary copy first.

However, to avoid having to deal with encoding them back to binary from the
parser itself, this helper is limited to dealing with unsplit and
unconcattened strings so that we can make some assumptions.

This is mainly intended for use for pass-through within the same memory.
    @sebmarkbage
    sebmarkbage committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    09b18d1 View commit details
    Browse the repository at this point in the history

  2. Leave large strings unencoded in Node streams 

    Also, let Node accept string chunks as long as they're following our
expected constraints.

This lets us test the mixed protocol using pass-throughs.
    @sebmarkbage
    sebmarkbage committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2898e07 View commit details
    Browse the repository at this point in the history

  3. Process Flight Chunks as Strings in renderToMarkup 

    This lets us avoid the dependency on TextDecoder/TextEncoder.
    @sebmarkbage
    sebmarkbage committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1ceacb3 View commit details
    Browse the repository at this point in the history