Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Implement captureStackTrace and owner stacks on the Server #30197

Merged
merged 2 commits into from
Jul 4, 2024
Merged

[Flight] Implement captureStackTrace and owner stacks on the Server #30197

merged 2 commits into from
Jul 4, 2024

Commits on Jul 3, 2024

  1. Wire up owner stacks in Flight 

    This exposes it to captureOwnerStack().

In this case we install it permanently as we only allow one RSC renderer
which then supports async contexts.

It also exposes it to component stack addendums that React adds to its own
console.errors. At least for now.
    @sebmarkbage
    sebmarkbage committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    aeffcc2 View commit details
    Browse the repository at this point in the history

  2. Omit the component stack from the replaying 

    Since getCurrentStack is now implemented, React appends component stacks
to its own logs. However, at the same time we've instrumented the console
so we need to strip them back out before sending to the client.

This is another reason we shouldn't append them from React.
    @sebmarkbage
    sebmarkbage committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b0becf2 View commit details
    Browse the repository at this point in the history