[Flight] Encode the name of a function as an object property #30325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Jul 12, 2024
| // We generate code where the call is at the line and column of the server executed code. | ||
| // This allows us to use the original source map as the source map of this fake file to | ||
| // point to the original source. | ||
| let code; | ||
| if (line <= 1) { | ||
| code = '_=>' + ' '.repeat(col < 4 ? 0 : col - 4) + '_()\n' + comment; | ||
| const minSize = encodedName.length + 8; |
There was a problem hiding this comment.
We cannot model a call on the first row with a column less than this.
sophiebits
reviewed
Jul 14, 2024
| @@ -1931,7 +1945,7 @@ function createFakeFunction<T>( | |||
| let fn: FakeFunction<T>; | |||
| try { | |||
| // eslint-disable-next-line no-eval | |||
| fn = (0, eval)(code); | |||
| fn = (0, eval)(code)[name]; | |||
| } catch (x) { | |||
| // If eval fails, such as if in an environment that doesn't support it, | |||
| // we fallback to creating a function here. It'll still have the right | |||
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
…k#30325) Unfortunately, Firefox doesn't include the name of a function in stack traces if you set it as either `.name` or `.displayName` at runtime. Only if you include it declarative. We also can't include it into a named function expression because not all possible names are expressible declaratively. E.g. spaces or punctuations. However, we can express any name if it's an object property and since object properties now give their name declarative to the function defined inside of them, we can declaratively express any name this way.
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
…k#30325) Unfortunately, Firefox doesn't include the name of a function in stack traces if you set it as either `.name` or `.displayName` at runtime. Only if you include it declarative. We also can't include it into a named function expression because not all possible names are expressible declaratively. E.g. spaces or punctuations. However, we can express any name if it's an object property and since object properties now give their name declarative to the function defined inside of them, we can declaratively express any name this way.
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, Firefox doesn't include the name of a function in stack traces if you set it as either
.nameor.displayNameat runtime. Only if you include it declarative.We also can't include it into a named function expression because not all possible names are expressible declaratively. E.g. spaces or punctuations.
However, we can express any name if it's an object property and since object properties now give their name declarative to the function defined inside of them, we can declaratively express any name this way.