Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Store babel scope on Environment #30328

Merged
merged 2 commits into from
Jul 17, 2024

Commits on Jul 15, 2024

  1. [compiler] Store babel scope on Environment

    Stores the Babel `Scope` object for the current function on the Environment, allowing access later for generating new globally unique names. The idea is to expose a small subset of the capabilities of the Scope API via Environment, so that the rest of the compiler remains decoupled from Babel. Ideally we'd use our own Scope implementation too, but we can punt on that for now since the parts we're using (global id generation) seem pretty reliable.
    
    [ghstack-poisoned]
    josephsavona committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0f32c76 View commit details
    Browse the repository at this point in the history
  2. Update on "[compiler] Store babel scope on Environment"

    Stores the Babel `Scope` object for the current function on the Environment, allowing access later for generating new globally unique names. The idea is to expose a small subset of the capabilities of the Scope API via Environment, so that the rest of the compiler remains decoupled from Babel. Ideally we'd use our own Scope implementation too, but we can punt on that for now since the parts we're using (global id generation) seem pretty reliable.
    
    [ghstack-poisoned]
    josephsavona committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ea5d8d2 View commit details
    Browse the repository at this point in the history