Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prettier for some blocklisted fixtures with invalid GraphQL #30425

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Jul 22, 2024

The invalid GraphQL in these fixtures somehow causes an unhandled promise rejection error when running yarn prettier-all. This fixes that issue by making the GraphQL valid.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 3:05pm

@react-sizebot
Copy link

react-sizebot commented Jul 22, 2024

The size diff is too large to display in a single comment. The CircleCI job contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 5c925f0

The invalid GraphQL in these fixtures somehow causes an unhandled promise rejection error when running `yarn prettier-all`. This fixes that issue by making the GraphQL valid.
@kassens kassens merged commit 41ecbad into facebook:main Jul 30, 2024
197 checks passed
@kassens kassens deleted the pr30425 branch July 30, 2024 18:23
github-actions bot pushed a commit to surenpoghosian/react that referenced this pull request Jul 30, 2024
…acebook#30425)

The invalid GraphQL in these fixtures somehow causes an unhandled
promise rejection error when running `yarn prettier-all`. This fixes
that issue by making the GraphQL valid.

DiffTrain build for commit facebook@41ecbad.
github-actions bot pushed a commit to surenpoghosian/react that referenced this pull request Jul 30, 2024
…acebook#30425)

The invalid GraphQL in these fixtures somehow causes an unhandled
promise rejection error when running `yarn prettier-all`. This fixes
that issue by making the GraphQL valid.

DiffTrain build for [41ecbad](facebook@41ecbad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants