Configure the requested environment and annotate tasks at boundary between environments #30455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
approved these changes
Jul 25, 2024
…tween environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables configuring the name of the requested environment.
When we currently use createTask, we start with a
"use server"annotation. This option basically configures that string.I now also deal with the case when switching environments along the owner path. If you go from
"Third Party"to"Server"to"Client", it'll have a task named"use third party"at the root, then"use server"and then finally"use client".We don't really have the concept of a Server Component making a request during render to then create another Server Component. Really the inner one should conceptually have the first one as its owner in that case. So currently the inner one will always have a null owner. We could somehow connect them in this server-to-server case.
We don't currently have a way to configure the
"use client"option but I figured maybe that could be inferred by the server environment that the Flight Client is executed within.Note: We did talk before about annotating each stack frame with the environment. You can effectively do that manually when parsing
rsc://React/{environment}/fromcaptureOwnerStack. However, we can't do that natively. At least not without deeper integration. Because it's the source map that's responsible for the actual function name of each stack frame - not what we give it at runtime. So for the native stacks, the task showing the change in environment is more practical.