[compiler] Make inserting outlined functions more resilient #30466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jul 25, 2024
To handle more cases, always append the synthetic outlined function as a new child of the module rather than make assumptions about the original function. This should handle whatever case where the original function expression may be a child of a variety of parents ghstack-source-id: 4a0d8619faeb238dbe68aba7cf3643323e72baa9 Pull Request resolved: #30466
facebook-github-bot
added
CLA Signed
React Core Team
poteto
added a commit
that referenced
this pull request
Jul 25, 2024
To handle more cases, always append the synthetic outlined function as a new child of the module rather than make assumptions about the original function. This should handle whatever case where the original function expression may be a child of a variety of parents ghstack-source-id: 8581edb8be706c0f4ce506caf7cd9b0f5a145bc8 Pull Request resolved: #30466
mofeiZ
approved these changes
Jul 25, 2024
poteto
added a commit
that referenced
this pull request
Jul 25, 2024
To handle more cases, always append the synthetic outlined function as a new child of the module rather than make assumptions about the original function. This should handle whatever case where the original function expression may be a child of a variety of parents ghstack-source-id: 8581edb8be706c0f4ce506caf7cd9b0f5a145bc8 Pull Request resolved: #30466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
To handle more cases, always append the synthetic outlined function as a
new child of the module rather than make assumptions about the original
function. This should handle whatever case where the original function
expression may be a child of a variety of parents