Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Rename NativeElement to HostInstance in the Bridge #30491

Merged
merged 9 commits into from
Jul 30, 2024
Merged

[DevTools] Rename NativeElement to HostInstance in the Bridge #30491

merged 9 commits into from
Jul 30, 2024
+145 −145

Commits on Jul 29, 2024

  1. Rename NativeNode to HostInstance in the RendererInterface 

    The term Native is overloaded with React Native nodes. Elsewhere in React
we call this concept HostInstance.
    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c78b88c View commit details
    Browse the repository at this point in the history

  2. Rename NativeElement to HostInstance in the Bridgd

    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ef3d256 View commit details
    Browse the repository at this point in the history

  3. Rename start/stopInspectingNative to InspectingHost in the Bridge 

    However, I don't rename it in the agent. These are slightly different.
It seems the agent ones are for controlling the React Native ones.

So frontend -> backend is "Host" but backend -> React Native is "Native".
    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f7a0adb View commit details
    Browse the repository at this point in the history

  4. Rename NativeElementsPanel to BuiltinElementsPanel 

    This isn't a React Native panel but one part of the surrounding DevTools.

We refer to Host more as the thing running React itself. I.e. where the
backend lives.

The DevTools itself needs a third term. So I went with Builtin.
    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b3508a7 View commit details
    Browse the repository at this point in the history

  5. Clarify types when they're React Native vs HTMLElement

    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    e2dd54a View commit details
    Browse the repository at this point in the history

  6. Rename Native in legacy renderer

    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2eec856 View commit details
    Browse the repository at this point in the history

  7. supportsNativeConsoleTasks -> supportsConsoleTasks

    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5cf264a View commit details
    Browse the repository at this point in the history

  8. Rename NativeElement terms to HostInstance in the frontend 

    The highlight ones are generic.

There's a lot of references to Native in the StyleEditor but that one is
indeed referring to React Native.
    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    09068c3 View commit details
    Browse the repository at this point in the history

  9. Fiber renderer

    @sebmarkbage
    sebmarkbage committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    18f44c6 View commit details
    Browse the repository at this point in the history