[ci] Add polling to download-build-artifacts #30515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 29, 2024
facebook-github-bot
added
CLA Signed
React Core Team
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 6 minutes for the build for that revision to complete. ghstack-source-id: 2176d7f49ed94121a19ed2a5a037af989ee25eda Pull Request resolved: #30515
|
Comparing: 6b82f3c...7108e0a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 6 minutes for the build for that revision to complete. ghstack-source-id: f7a48547663055f993d5c0464b154e95796e093b Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 6 minutes for the build for that revision to complete. ghstack-source-id: 6e0b68587b7a44b98857739691f87a11933d798b Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 513e1335f152c8dc5e46274fa49214bf661ec508 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 409c79c1ec74834f17c6fe9a3f114b767f45b722 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: f95640dc641958cfe1c97b068f06d60694f3c0f3 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: c6d3d0e047fde6bf1b26b9df0f1b8c82edb94fea Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 886c6b89d8b9d6e09b87239b749536798501b2fe Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 6a954638a800fbea8081e6fba35ee4b4437731c5 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 6a954638a800fbea8081e6fba35ee4b4437731c5 Pull Request resolved: #30515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.
This PR adds a simple polling mechanism that waits up to 6 minutes for
the build for that revision to complete.