Build all bundles required by flight fixture with build-for-flight-dev
#30534
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following bundles were missing so that the flight fixture could not be started after running `yarn build-for-flight-dev` on a fresh clone: - `react-server-dom-webpack-node-loader.production.js` (requires `ESM_PROD`) - `react-server-dom-webpack-plugin.js` (requires `NODE_ES2015`) - `react-dom.react-server.development.js` - `react.react-server.development.js` Since we now need to specify a list of bundle types, we had to fix the `shouldSkipBundle` function, which apparently was broken in facebook#29906.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 3208e73...f5d912b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following bundles were missing so that the flight fixture could not be started after running
yarn build-for-flight-devon a fresh clone:react-server-dom-webpack-node-loader.production.js(requiresESM_PROD)react-server-dom-webpack-plugin.js(requiresNODE_ES2015)react-dom.react-server.development.jsreact.react-server.development.jsSince we now need to specify a list of bundle types, we had to fix the
shouldSkipBundlefunction, which apparently was broken in #29906.