Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Validate against JSX in try statements #30725

Merged
merged 4 commits into from
Aug 19, 2024

Commits on Aug 16, 2024

  1. [compiler] Validate against JSX in try statements

    Per comments on the new validation pass, this disallows creating JSX (expression/fragment) within a try statement. Developers sometimes use this pattern thinking that they can catch errors during the rendering of the element, without realizing that rendering is lazy. The validation allows us to teach developers about the error boundary pattern.
    
    [ghstack-poisoned]
    josephsavona committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    302ca32 View commit details
    Browse the repository at this point in the history
  2. Update on "[compiler] Validate against JSX in try statements"

    Per comments on the new validation pass, this disallows creating JSX (expression/fragment) within a try statement. Developers sometimes use this pattern thinking that they can catch errors during the rendering of the element, without realizing that rendering is lazy. The validation allows us to teach developers about the error boundary pattern.
    
    [ghstack-poisoned]
    josephsavona committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    1a37c1e View commit details
    Browse the repository at this point in the history
  3. Update on "[compiler] Validate against JSX in try statements"

    Per comments on the new validation pass, this disallows creating JSX (expression/fragment) within a try statement. Developers sometimes use this pattern thinking that they can catch errors during the rendering of the element, without realizing that rendering is lazy. The validation allows us to teach developers about the error boundary pattern.
    
    [ghstack-poisoned]
    josephsavona committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    56d58aa View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Update on "[compiler] Validate against JSX in try statements"

    Per comments on the new validation pass, this disallows creating JSX (expression/fragment) within a try statement. Developers sometimes use this pattern thinking that they can catch errors during the rendering of the element, without realizing that rendering is lazy. The validation allows us to teach developers about the error boundary pattern.
    
    [ghstack-poisoned]
    josephsavona committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    1c3d4bd View commit details
    Browse the repository at this point in the history