Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forcing a build in artifacts workflow dispatch #31027

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Sep 23, 2024

Stack from ghstack (oldest at bottom):

Sometimes it is useful to bypass the revision check when we need to make
changes to the runtime_commit_artifacts script. The force input can be
passed via the GitHub UI for manual runs of the workflow.

Screenshot 2024-09-23 at 3 31 35 PM

[ghstack-poisoned]
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:33pm

poteto added a commit that referenced this pull request Sep 23, 2024
Sometimes it is useful to bypass the revision check when we need to make
changes to the runtime_commit_artifacts script. The `force` input can be
passed via the GitHub UI for manual runs of the workflow.

ghstack-source-id: e77d8ab1309998a0c0a1c2bd0d0ebd130a745294
Pull Request resolved: #31027
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 23, 2024
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
Sometimes it is useful to bypass the revision check when we need to make
changes to the runtime_commit_artifacts script. The `force` input can be
passed via the GitHub UI for manual runs of the workflow.

ghstack-source-id: ee934842213eb6be7acfe8ef913925e276da7f8b
Pull Request resolved: #31027
@react-sizebot
Copy link

react-sizebot commented Sep 23, 2024

Comparing: 79bcf6e...610bf04

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.10 kB 509.10 kB = 91.06 kB 91.06 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.04 kB 514.04 kB = 91.78 kB 91.78 kB
facebook-www/ReactDOM-prod.classic.js = 603.53 kB 603.53 kB = 106.78 kB 106.78 kB
facebook-www/ReactDOM-prod.modern.js = 579.76 kB 579.76 kB = 102.88 kB 102.88 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 388494c

[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
Sometimes it is useful to bypass the revision check when we need to make
changes to the runtime_commit_artifacts script. The `force` input can be
passed via the GitHub UI for manual runs of the workflow.

ghstack-source-id: cf9e32c01a565d86980277115f41e3e116adf376
Pull Request resolved: #31027
Copy link
Contributor

@jackpope jackpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! I was having trouble testing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants