Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove flag enableAddPropertiesFastPath #31062

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Sep 25, 2024

The experiment was tested internally and rolled out, replacing the flag with true.

The experiment was tested internally and rolled out, replacing the flag with `true`.
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 5:32pm

@react-sizebot
Copy link

Comparing: f9ebd85...403bab0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.10 kB 509.10 kB = 91.06 kB 91.06 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.04 kB 514.04 kB = 91.78 kB 91.78 kB
facebook-www/ReactDOM-prod.classic.js = 603.53 kB 603.53 kB = 106.78 kB 106.78 kB
facebook-www/ReactDOM-prod.modern.js = 579.76 kB 579.76 kB = 102.88 kB 102.88 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-prod.js +0.29% 351.42 kB 352.43 kB +0.29% 61.53 kB 61.71 kB
react-native/implementations/ReactFabric-profiling.js +0.27% 376.68 kB 377.68 kB +0.27% 65.22 kB 65.39 kB

Generated by 🚫 dangerJS against 3c83220

Copy link
Contributor

@yungsters yungsters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... @dmytrorykun, can we also change addNestedProperty to use fastAddProperties (and then delete addProperties and rename fastAddProperties to addProperties)?

@kassens kassens merged commit de43d56 into facebook:main Oct 9, 2024
184 checks passed
@kassens kassens deleted the pr31062 branch October 9, 2024 20:46
@kassens
Copy link
Member Author

kassens commented Oct 9, 2024

Landing as we should run a different experiment if we also change the update path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants