Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make prerendering always non-blocking" #31080

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Revert "Make prerendering always non-blocking" #31080

merged 1 commit into from
Sep 26, 2024
+137 −298

Conversation

rickhanlonii
Copy link
Member

Reverts #31056

@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:44pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 26, 2024
@react-sizebot
Copy link

Comparing: 60b1420...3c0988b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.25% 507.20 kB 508.49 kB +0.12% 90.80 kB 90.91 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.25% 512.13 kB 513.42 kB +0.13% 91.52 kB 91.64 kB
facebook-www/ReactDOM-prod.classic.js = 603.73 kB 603.02 kB = 106.84 kB 106.64 kB
facebook-www/ReactDOM-prod.modern.js = 579.95 kB 579.21 kB = 102.92 kB 102.72 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.production.js +0.45% 306.30 kB 307.67 kB +0.18% 54.28 kB 54.38 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js +0.45% 306.30 kB 307.67 kB +0.18% 54.28 kB 54.38 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js +0.45% 306.36 kB 307.73 kB +0.18% 54.31 kB 54.40 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js +0.45% 306.55 kB 307.92 kB +0.18% 54.34 kB 54.44 kB
oss-stable-rc/react-art/cjs/react-art.production.js +0.44% 296.97 kB 298.26 kB +0.21% 51.14 kB 51.24 kB
oss-stable-semver/react-art/cjs/react-art.production.js +0.44% 296.97 kB 298.26 kB +0.21% 51.14 kB 51.24 kB
oss-stable/react-art/cjs/react-art.production.js +0.44% 297.03 kB 298.33 kB +0.21% 51.16 kB 51.26 kB
oss-experimental/react-art/cjs/react-art.production.js +0.43% 301.55 kB 302.84 kB +0.16% 51.93 kB 52.01 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.39% 324.42 kB 325.70 kB +0.15% 57.23 kB 57.31 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.37% 346.28 kB 347.57 kB +0.13% 60.27 kB 60.35 kB
react-native/implementations/ReactFabric-prod.js +0.37% 351.66 kB 352.95 kB +0.14% 61.65 kB 61.74 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.36% 361.33 kB 362.61 kB +0.11% 63.34 kB 63.41 kB
react-native/implementations/ReactFabric-profiling.js +0.34% 376.92 kB 378.21 kB +0.13% 65.29 kB 65.38 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.profiling.js +0.34% 409.43 kB 410.80 kB +0.14% 66.55 kB 66.65 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js +0.34% 409.43 kB 410.80 kB +0.14% 66.55 kB 66.65 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js +0.34% 409.45 kB 410.82 kB +0.14% 66.57 kB 66.67 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js +0.33% 388.33 kB 389.62 kB +0.14% 63.69 kB 63.78 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.33% 386.58 kB 387.87 kB +0.11% 67.17 kB 67.24 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.production.js +0.33% 383.25 kB 384.52 kB +0.13% 62.85 kB 62.93 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js +0.33% 383.25 kB 384.52 kB +0.13% 62.85 kB 62.93 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js +0.33% 383.27 kB 384.54 kB +0.13% 62.87 kB 62.95 kB
oss-stable-rc/react-art/cjs/react-art.development.js +0.30% 551.64 kB 553.28 kB +0.12% 89.48 kB 89.59 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.30% 551.64 kB 553.28 kB +0.12% 89.48 kB 89.59 kB
oss-stable/react-art/cjs/react-art.development.js +0.30% 551.71 kB 553.34 kB +0.11% 89.51 kB 89.61 kB
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.development.js +0.28% 547.21 kB 548.73 kB +0.11% 89.63 kB 89.73 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.28% 547.21 kB 548.73 kB +0.11% 89.63 kB 89.73 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.28% 547.24 kB 548.76 kB +0.11% 89.65 kB 89.74 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.28% 547.28 kB 548.80 kB +0.11% 89.66 kB 89.75 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.27% 580.85 kB 582.40 kB +0.10% 94.76 kB 94.86 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.27% 571.99 kB 573.51 kB +0.15% 93.72 kB 93.86 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.27% 572.00 kB 573.52 kB +0.15% 93.72 kB 93.86 kB
oss-stable-rc/react-dom/cjs/react-dom-client.production.js +0.25% 507.10 kB 508.38 kB +0.12% 90.78 kB 90.89 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js +0.25% 507.10 kB 508.38 kB +0.12% 90.78 kB 90.89 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.25% 507.20 kB 508.49 kB +0.12% 90.80 kB 90.91 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.25% 512.13 kB 513.42 kB +0.13% 91.52 kB 91.64 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.25% 643.30 kB 644.91 kB +0.09% 105.65 kB 105.74 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js +0.25% 421.77 kB 422.82 kB +0.05% 68.86 kB 68.89 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js +0.24% 526.86 kB 528.15 kB +0.12% 95.15 kB 95.27 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.development.js +0.24% 634.49 kB 636.04 kB +0.08% 102.07 kB 102.15 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.24% 634.49 kB 636.04 kB +0.08% 102.07 kB 102.15 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.24% 634.51 kB 636.06 kB +0.09% 102.09 kB 102.17 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.profiling.js +0.24% 537.52 kB 538.81 kB +0.15% 95.55 kB 95.69 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js +0.24% 537.52 kB 538.81 kB +0.15% 95.55 kB 95.69 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js +0.24% 537.63 kB 538.92 kB +0.15% 95.57 kB 95.71 kB
react-native/implementations/ReactFabric-dev.js +0.24% 632.27 kB 633.78 kB +0.09% 103.63 kB 103.72 kB
oss-experimental/react-art/cjs/react-art.development.js +0.23% 569.49 kB 570.78 kB +0.08% 92.27 kB 92.35 kB
facebook-www/ReactART-prod.modern.js = 353.07 kB 352.31 kB = 59.95 kB 59.77 kB

Generated by 🚫 dangerJS against 280a522

@poteto poteto merged commit 76aee6f into main Sep 26, 2024
184 checks passed
@poteto poteto deleted the revert-31056-nonblocking-sync-prerenders branch September 26, 2024 20:49
This was referenced Sep 26, 2024
Closed
Merged
gnoff added a commit to vercel/next.js that referenced this pull request Sep 27, 2024
@vercel-release-bot @gnoff
Upgrade React from 778e1ed2-20240926 to 3edc000d-20240926 (#70560)
af8af5e 
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`**

[diff
facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000)

<details>
<summary>React upstream changes</summary>

- facebook/react#31078
- facebook/react#31083
- facebook/react#31079
- facebook/react#31080
- facebook/react#31076
- facebook/react#31021
- facebook/react#31069
- facebook/react#31074
- facebook/react#31073
- facebook/react#31047
- facebook/react#31046
- facebook/react#31045
- facebook/react#31072
- facebook/react#30980
- facebook/react#30463
- facebook/react#30694
- facebook/react#31039
- facebook/react#31048
- facebook/react#31068

</details>

---------

Co-authored-by: Josh Story <story@hey.com>
abhi12299 pushed a commit to abhi12299/next.js that referenced this pull request Sep 29, 2024
@vercel-release-bot @gnoff @abhi12299
Upgrade React from 778e1ed2-20240926 to 3edc000d-20240926 (vercel…
b3ae1e6 
…#70560)

**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`**

[diff
facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000)

<details>
<summary>React upstream changes</summary>

- facebook/react#31078
- facebook/react#31083
- facebook/react#31079
- facebook/react#31080
- facebook/react#31076
- facebook/react#31021
- facebook/react#31069
- facebook/react#31074
- facebook/react#31073
- facebook/react#31047
- facebook/react#31046
- facebook/react#31045
- facebook/react#31072
- facebook/react#30980
- facebook/react#30463
- facebook/react#30694
- facebook/react#31039
- facebook/react#31048
- facebook/react#31068

</details>

---------

Co-authored-by: Josh Story <story@hey.com>
@markerikson markerikson mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpope jackpope jackpope approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @jackpope @poteto @facebook-github-bot