[playground] Decouple playground from compiler #31081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: ec2d5fb7721668772b76ddef36e399d09a47cf44 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: ec2d5fb7721668772b76ddef36e399d09a47cf44 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 5cb0ccf5b463ec63c24149b18d4e23facb30b60c Pull Request resolved: #31081
|
Comparing: 3edc000...4a0a743 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 2ae44866104dac5f40cb19deb290280921289402 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 7f4eca02497419be14dd2f87c92533575ddfe816 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 920f94a07266851f85fc469acfe7837f869c1744 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 80c90217b802c601221e2a1016c3df6ebd59db07 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 9d11a365001134a75ed568ef7d9cb2b9d3d2528e Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: e2067656c718d8999d0cb3f817a3b4d03ef12c29 Pull Request resolved: #31081
josephsavona
approved these changes
Sep 27, 2024
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: d6b0b3957859d9dbf9e67849af6294f0ea065abb Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: b7aa8352bee084e2ece35b45bc781518df136eb7 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: b7aa8352bee084e2ece35b45bc781518df136eb7 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: ab63e668d3e5b9466ab2e24fcfd249f44b90ff03 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 8157b50c43d6dd314bd0647cb6f428cfc8a9346b Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 61a8bf9e49464d140770eecf1c44201e125c3969 Pull Request resolved: #31081
|
finally |
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 56ab064b2fc45366f5d96d37c5d4c5dc26590234 Pull Request resolved: #31081
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 56ab064b2fc45366f5d96d37c5d4c5dc26590234 Pull Request resolved: #31081
github-actions bot
pushed a commit
to AreaLayer/react
that referenced
this pull request
Sep 29, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 56ab064b2fc45366f5d96d37c5d4c5dc26590234 Pull Request resolved: facebook#31081 DiffTrain build for [db24098](facebook@db24098)
github-actions bot
pushed a commit
to AreaLayer/react
that referenced
this pull request
Sep 29, 2024
Currently the playground is setup as a linked workspace for the compiler which complicates our yarn workspace setup and means that snap can sometimes pull in a different version of react than was otherwise specified. There's no real reason to have these workspaces combined so let's split them up. ghstack-source-id: 56ab064b2fc45366f5d96d37c5d4c5dc26590234 Pull Request resolved: facebook#31081 DiffTrain build for [db24098](facebook@db24098)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently the playground is setup as a linked workspace for the
compiler which complicates our yarn workspace setup and means that snap
can sometimes pull in a different version of react than was otherwise
specified.
There's no real reason to have these workspaces combined so let's split
them up.