Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope #31103

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Sep 30, 2024

[ghstack-poisoned]
[ghstack-poisoned]
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 3:51pm

[ghstack-poisoned]
[ghstack-poisoned]
mofeiZ added a commit that referenced this pull request Sep 30, 2024
ghstack-source-id: 5dba5c0b1d2e17c1d8d8a88a363f28ad7ac4746a
Pull Request resolved: #31103
[ghstack-poisoned]
[ghstack-poisoned]
mofeiZ added a commit that referenced this pull request Oct 1, 2024
ghstack-source-id: dc8753a36d21db3fb596bf3c3b4b55fe9f6f995d
Pull Request resolved: #31103
@mofeiZ mofeiZ marked this pull request as ready for review October 3, 2024 15:11
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super interesting. We should discuss what the fix is for this case

[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants