fix[react-devtools]: record timeline data only when supported #31154
+126
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hoxyq
force-pushed
the
react-devtools/only-record-timeline-data-when-requested
branch
from
a2751c2
to
0f68c00
Compare
hoxyq
force-pushed
the
react-devtools/only-record-timeline-data-when-requested
branch
from
0f68c00
to
55baf7b
Compare
hoxyq
force-pushed
the
react-devtools/only-record-timeline-data-when-requested
branch
from
55baf7b
to
d9b913b
Compare
hoxyq
force-pushed
the
react-devtools/only-record-timeline-data-when-requested
branch
from
d9b913b
to
0415673
Compare
EdmondChuiHW
approved these changes
Oct 9, 2024
| ) { | ||
| const mergedProfilingSettings: ProfilingSettings | void = | ||
| typeof profilingSettings === 'object' && profilingSettings != null | ||
| ? {...profilingSettings, recordTimeline: false} |
There was a problem hiding this comment.
Wait so does it mean we will never respect recordTimeline: true pass in from initialize? Could we add a comment explaining this? e.g. if store is the only way to set this to true
There was a problem hiding this comment.
Good catch, yeah, I should just default it to false here. Forgot that react-devtools-core might be used not only for React Native.
hoxyq
force-pushed
the
react-devtools/only-record-timeline-data-when-requested
branch
from
0415673
to
2b2d55e
Compare
hoxyq
deleted the
react-devtools/only-record-timeline-data-when-requested
branch
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #31132. See last commit.
There are 2 issues:
We can't currently fix the second one, because we would still need to generate all these stacks, and this would still take quite a lot of time. As of right now, we can't generate a component stack lazily without relying on the fact that reference to the Fiber is not stale. With
enableOwnerStackswe could populate component stacks in some collection, which would be cached at the Backend, and then returned only once Frontend asks for it. This approach also eliminates the need for keeping a reference to a Fiber.