Flip __DEV__ assignments in ReactDOMProduction-test #6399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these two appear assignments need to be flipped around.
This test works correctly because today it only relies on fbjs
warning
s which are not affected by__DEV__
global and read fromprocess.env.NODE_ENV
which is set a few lines below.In my testing, adding another test that actually relies on
__DEV__
shows that the current behavior is incorrect.