Cleanup environments doc #6519
Cleanup environments doc #6519
Conversation
zpao
commented
Apr 14, 2016
zpao
commented
- Use correct "Note" formatting so they render correctly
- reordered sections so Node is first
- Use "Node.js" consistently (it is a product name just like Nashorn)
- added/tweaked some of the text
- simplified the Java code so it doesn't hit the internet.
|
I haven't actually written any Java in a long time so let me know if this code is bad. Mostly I wanted to simplify the code as much as possible so I made it read react from disk instead of hitting the internet which gets rid of a few imports and half the code. I would posit that's a better practice anyway and ensures we won't miss updating some URLs later. The code also fits on the page now without horizontal scrolling. before: https://cloudup.com/cxoRloUs8DG |
| System.out.println(nashorn.eval("ReactDOMServer.renderToString(React.createElement('div', {}, 'Hello World!'));")); | ||
| } | ||
| nashorn.eval(new FileReader("path/to/react.js")); | ||
| nashorn.eval(new FileReader("path/to/react-dom-server.js")); |
There was a problem hiding this comment.
I think we should have a comments indicating where this file can be downloaded, because we don't put the react-dom-server.js build on the downloads page so it's not obvious where to get that file.
There was a problem hiding this comment.
// These files can be downloaded as a part of the starter kit from https://facebook.github.io/react
Your java changes look fine to me. Only red flag is that you don't close the FileReader (it's not obvious to me from the code if eval would close it automatically, though it probably would). Probably not a big deal / is fine as-is. Other than that, the changes look good 👍 I don't think it actually matters if we hit www verses if we hit local disk. Neither one should be on a production code path. The ScriptEngines should be pooled and re-used for requests, so you'd never hit disk/web for an incoming request anyway. |
I copied that right from https://docs.oracle.com/javase/8/docs/technotes/guides/scripting/prog_guide/api.html :) It might not be perfectly right but figured good enough if they're using that pattern. |
- Use correct "Note" formatting so they render correctly - reordered sections so Node is first - Use "Node.js" consistently (it is a product name just like Nashorn) - added/tweaked some of the text - simplified the Java code so it doesn't hit the internet.
|
👍 I’ll keep these in mind for the next time! |
Cleanup environments doc (cherry picked from commit befb70e)
