Add feature flag to log missing data using invariant in prod

Summary: * Add feature flag to log missing data using invariant in prod * This (maybe) will allow us to confirm a hypothesis about what is occurring, which is that (at least certain) MIDs are preceded by this event occuring. * Do not turn on that feature flag, yet Reviewed By: tyao1 Differential Revision: D43911595 fbshipit-source-id: 57056d80f6efdfd7ff808cd4f9e0cffb2ece79c3
facebook · Mar 21, 2023 · 3073f1e · 3073f1e
1 parent cc478a6
commit 3073f1e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/packages/react-relay/relay-hooks/react-cache/readFragmentInternal_REACT_CACHE.js b/packages/react-relay/relay-hooks/react-cache/readFragmentInternal_REACT_CACHE.js
@@ -27,6 +27,7 @@ const {getQueryResourceForEnvironment} = require('../QueryResource');
 const invariant = require('invariant');
 const {
   __internal: {fetchQuery: fetchQueryInternal},
+  RelayFeatureFlags,
   createOperationDescriptor,
   getPendingOperationsForFragment,
   getSelector,
@@ -268,7 +269,7 @@ function readFragmentInternal_REACT_CACHE(
     data = state.snapshots.map(s => s.data);
   }
 
-  if (__DEV__) {
+  if (RelayFeatureFlags.LOG_MISSING_RECORDS_IN_PROD || __DEV__) {
     if (
       fragmentRef != null &&
       (data === undefined ||

diff --git a/packages/react-relay/relay-hooks/react-cache/useFragmentInternal_REACT_CACHE.js b/packages/react-relay/relay-hooks/react-cache/useFragmentInternal_REACT_CACHE.js
@@ -32,6 +32,7 @@ const invariant = require('invariant');
 const {useDebugValue, useEffect, useMemo, useRef, useState} = require('react');
 const {
   __internal: {fetchQuery: fetchQueryInternal},
+  RelayFeatureFlags,
   areEqualSelectors,
   createOperationDescriptor,
   getPendingOperationsForFragment,
@@ -565,7 +566,7 @@ function useFragmentInternal_REACT_CACHE(
     data = state.snapshot.data;
   }
 
-  if (__DEV__) {
+  if (RelayFeatureFlags.LOG_MISSING_RECORDS_IN_PROD || __DEV__) {
     if (
       fragmentRef != null &&
       (data === undefined ||

diff --git a/packages/react-relay/relay-hooks/useFragmentNode.js b/packages/react-relay/relay-hooks/useFragmentNode.js
@@ -17,7 +17,7 @@ const {getFragmentResourceForEnvironment} = require('./FragmentResource');
 const useRelayEnvironment = require('./useRelayEnvironment');
 const useUnsafeRef_DEPRECATED = require('./useUnsafeRef_DEPRECATED');
 const {useEffect, useState} = require('react');
-const {getFragmentIdentifier} = require('relay-runtime');
+const {RelayFeatureFlags, getFragmentIdentifier} = require('relay-runtime');
 const warning = require('warning');
 
 type ReturnType<TFragmentData: mixed> = {
@@ -99,7 +99,7 @@ function useFragmentNode<TFragmentData: mixed>(
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [environment, fragmentIdentifier]);
 
-  if (__DEV__) {
+  if (RelayFeatureFlags.LOG_MISSING_RECORDS_IN_PROD || __DEV__) {
     if (
       fragmentRef != null &&
       (fragmentResult.data === undefined ||

diff --git a/packages/relay-runtime/util/RelayFeatureFlags.js b/packages/relay-runtime/util/RelayFeatureFlags.js
@@ -31,6 +31,7 @@ export type FeatureFlags = {
   USE_REACT_CACHE: boolean,
   USE_REACT_CACHE_LEGACY_TIMEOUTS: boolean,
   ENABLE_QUERY_RENDERER_SET_STATE_PREVENTION: boolean,
+  LOG_MISSING_RECORDS_IN_PROD: boolean,
 };
 
 const RelayFeatureFlags: FeatureFlags = {
@@ -51,6 +52,7 @@ const RelayFeatureFlags: FeatureFlags = {
   USE_REACT_CACHE: false,
   USE_REACT_CACHE_LEGACY_TIMEOUTS: true,
   ENABLE_QUERY_RENDERER_SET_STATE_PREVENTION: false,
+  LOG_MISSING_RECORDS_IN_PROD: false,
 };
 
 module.exports = RelayFeatureFlags;