Back out "Stub out handling of Relay Resolvers in RelayReader"

Reviewed By: tyao1 Differential Revision: D27579262 fbshipit-source-id: 22193bc69c4d920d403732fd44a1344544c98edc
facebook · Apr 6, 2021 · 3b8ee7a · 3b8ee7a
1 parent b12088e
commit 3b8ee7a
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 443 deletions.
diff --git a/packages/relay-runtime/store/RelayReader.js b/packages/relay-runtime/store/RelayReader.js
@@ -28,7 +28,6 @@ const {
   LINKED_FIELD,
   MODULE_IMPORT,
   REQUIRED_FIELD,
-  RELAY_RESOLVER,
   SCALAR_FIELD,
   STREAM,
 } = require('../util/RelayConcreteNode');
@@ -328,16 +327,6 @@ class RelayReader {
           }
           break;
         }
-        case RELAY_RESOLVER: {
-          if (!RelayFeatureFlags.ENABLE_RELAY_RESOLVERS) {
-            throw new Error('Relay Resolver fields are not yet supported.');
-          }
-          const {name, alias, resolverModule} = selection;
-          // TODO: Create the key
-          const key = ({}: any); // flowlint-line unclear-type:off
-          data[alias ?? name] = resolverModule(key);
-          break;
-        }
         case FRAGMENT_SPREAD:
           this._createFragmentPointer(selection, record, data);
           break;

diff --git a/packages/relay-runtime/store/__tests__/RelayReader-Resolver-test.js b/packages/relay-runtime/store/__tests__/RelayReader-Resolver-test.js
diff --git a/...ages/relay-runtime/store/__tests__/__generated__/RelayReaderResolverTest1Query.graphql.js b/...ages/relay-runtime/store/__tests__/__generated__/RelayReaderResolverTest1Query.graphql.js
diff --git a/...ages/relay-runtime/store/__tests__/__generated__/RelayReaderResolverTest2Query.graphql.js b/...ages/relay-runtime/store/__tests__/__generated__/RelayReaderResolverTest2Query.graphql.js
diff --git a/packages/relay-runtime/util/ReaderNode.js b/packages/relay-runtime/util/ReaderNode.js
@@ -206,18 +206,6 @@ export type ReaderRequiredField = {|
   +path: string,
 |};
 
-export type ReaderRelayResolver = {|
-  +kind: 'RelayResolver',
-  +alias: ?string,
-  +name: string,
-  +fragment: ReaderFragmentSpread,
-  +resolverModule: (rootKey: {
-    +$data?: any, // flowlint-line unclear-type:off
-    +$fragmentRefs: any, // flowlint-line unclear-type:off
-    ...
-  }) => mixed,
-|};
-
 export type ReaderSelection =
   | ReaderCondition
   | ReaderClientExtension
@@ -229,8 +217,7 @@ export type ReaderSelection =
   | ReaderInlineFragment
   | ReaderModuleImport
   | ReaderStream
-  | ReaderRequiredField
-  | ReaderRelayResolver;
+  | ReaderRequiredField;
 
 export type ReaderVariableArgument = {|
   +kind: 'Variable',

diff --git a/packages/relay-runtime/util/RelayConcreteNode.js b/packages/relay-runtime/util/RelayConcreteNode.js
@@ -84,7 +84,6 @@ const RelayConcreteNode = {
   LIST_VALUE: 'ListValue',
   LOCAL_ARGUMENT: 'LocalArgument',
   MODULE_IMPORT: 'ModuleImport',
-  RELAY_RESOLVER: 'RelayResolver',
   REQUIRED_FIELD: 'RequiredField',
   OBJECT_VALUE: 'ObjectValue',
   OPERATION: 'Operation',